fix: prevent duplicated characters in typing animation. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed setDisplayedText logic to avoid duplicated characters by updating it to use text.substring(..) instead of concatenating with prevState and text.charAt(i).
|
@joacoc is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
|
wasn't able to replicate the issue - do you have a video or something? what exactly happened? |
|
It took me a bit to find a proper way to replicate it easily: recording timelines in Safari, or adding a compute-intensive component next to In the second 17, it is visible that the typing animation duplicates characters. Why this happens, I'm not 100% sure. Browser: Safari (Version 17.4) Test.mp4 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dillionverma
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
<TypingAnimation />component logic to avoid duplicated characters by updating it to usetext.substring(..)instead of concatenating withprevState + text.charAt(i).Context
Using small durations, e.g.,
<TypingAnimation duration={5} />, can duplicate characters. This does not always happen, but when switching tabs or when the application is in the background, it is more prone to happen.