Incorrect argument to malloc

[sdevlin]

https://github.com/skeeto/emacsql/blob/c82a0e6b4d256a3743b718cfb640fa9efc045f6e/sqlite/emacsql.c#L45

In the referenced code, the argument to malloc is incorrect. Both the type and the variable are named buffer, but sizeof prefers the variable. Since the variable is a pointer, only the size of a pointer is allocated.

[skeeto]

Thanks! It's probably gone unnoticed so long because malloc() typically allocates double the pointer size at a minimum, and so the real allocation worked out anyway. Revisiting this old code, I see I still had a whole lot to learn about C 8 years ago! If I wrote it today it would look quite different.

[sdevlin]

No problem, I've surely written similar code as well. 🙂

Thanks for the quick fix!