Rename buffer type name to avoid compiler confusion (#78) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable name is the same as the type, causing the wrong value to
be returned from the buffer_create() function. The buffer_create()
caller would see buffer size 0, causing trouble when growing the
buffer when reading data ("middleware out of memory").
This addresses issue magit#78 which shows this error message in a Termux environment.
|
Thanks @bram85 your fix also fixed a similar issue faced by me while using magit/forge in a Termux environment. Thanks again. @skeeto please look into this and merge this pull request, as many Termux users are facing the issue. |
|
This fixed an issue I was having with org-roam. |
|
This also fixed my issues with org-roam in termux. |
|
My emacs setup with magit-forge and org-roam is finally working now in termux. Many thanks to the author of this patch and this repository. Hopefully, this will be merged soon. |
|
@tarsius Yes, looks like your fork (with the commit referenced) works OK on Termux. |
|
Thanks for getting back to me! (It's not a fork, I am the new maintainer.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable name is the same as the type, causing the wrong value to
be returned from the buffer_create() function. The buffer_create()
caller would see buffer size 0, causing trouble when growing the
buffer when reading data ("middleware out of memory").
This addresses issue #78 which shows this error message in a Termux environment.