Fix SQL truncated when print-level or print-length are changed #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For long values or statements (like saving entire hash tables into a
field, for instance), if print-level and print-length were not reset
to nil, `format` (`prin1-to-string` under the hood) would truncate the
string, leading to an invalid value being sent.
;; Last 5 characters of the string
;; (eval-last-sexp does its own truncation)
(s-right 5 (format "%s" (make-list 100 t)))
;; -> " t t)" if the result is not truncated
;; " ...)" if it is
tarsius
force-pushed
the
fix-truncation
branch
from
24de26b
to
2e9e2d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For long values or statements (like saving entire hash tables into a field, for instance), if print-level and print-length were not reset to nil,
format(prin1-to-stringunder the hood) would truncate the string, leading to an invalid value being sent.