Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request template is not loaded #327

Closed
scottgrayson opened this issue Jan 13, 2021 · 3 comments
Closed

Pull request template is not loaded #327

scottgrayson opened this issue Jan 13, 2021 · 3 comments
Labels
obsolete This issue has already been fixed

Comments

@scottgrayson
Copy link

Please explain
(1) what behavior you expected
forge-create-pullreq should load the PROJECT_ROOT/.github/pull_request_template.md
(2) what behavior you observed
forge-create-pullreq does not load the template. instead it uses the message for the last commit
(3) and how we can reproduce the issue.

@tarsius
Copy link
Member

tarsius commented Jan 14, 2021

Are you using the latest version? This is supposed to work now.

@scottgrayson
Copy link
Author

If i describe the package i get

    Package: forge
     Source: Straight
     Pinned: 953764d2bb57b6bbaec4a2048722050fd15732db
      Build: grafted, HEAD -> master, origin/master, origin/HEAD c4ae0f2 2020-12-29 10:39:00 +0100
             Build location: ~/.emacs.d/.local/straight/build-28.0.50/forge/
             Repo location: ~/.emacs.d/.local/straight/repos/forge/
     Recipe: (:type git :flavor melpa :files
       ("lisp/*.el" "docs/forge.texi" "forge-pkg.el")
       :host github :repo "magit/forge" :package "forge" :local-repo "forge")
   Homepage: https://github.com/magit/forge
    Modules: Declared by the following Doom modules:
             :tools magit (readme)
    Configs: This package is configured in the following locations:
             modules/tools/magit/config.el:119:(use-package! forge
             modules/tools/magit/config.el:167:  (after! forge

@tarsius
Copy link
Member

tarsius commented Jan 17, 2021

953764d

I fixed it more recently than that, in 3a647f1.

Please always update before reporting an issue to see whether it has already been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
obsolete This issue has already been fixed
Projects
None yet
Development

No branches or pull requests

2 participants