Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-blame support #19

Closed
nurpax opened this issue Jun 6, 2010 · 8 comments
Closed

git-blame support #19

nurpax opened this issue Jun 6, 2010 · 8 comments
Labels
enhancement New feature or request

Comments

@nurpax
Copy link

nurpax commented Jun 6, 2010

Magit doesn't seem to support git-blame at all. This is one of the git features that I think really benefits from Emacs integration; it's cumbersome to use git-blame on the command line.

@vanicat
Copy link
Member

vanicat commented Jun 6, 2010

you could try mo-git-blame

@nurpax
Copy link
Author

nurpax commented Jun 6, 2010

mo-git-blame promising. However, it seems there's a dependency to the vc git mode as when I ran M-x mo-git-blame-current, all I got was this error:

Loading /home/jhellsten/emacs/lisp/mo-git-blame/mo-git-blame.el (source)...done
Loading cl-macs...done
Running 'git cat-file'... done
vc-registered: Wrong type argument: stringp, nil

Loading /home/jhellsten/emacs/lisp/mo-git-blame/mo-git-blame.el (source)...done
Loading cl-macs...done
Running 'git cat-file'... done
vc-registered: Wrong type argument: stringp, nil

@voins
Copy link
Contributor

voins commented Jun 7, 2010

Has anyone already started to work on it? I'm planning to integrate mo-git-blame into magit, it will take some time.

@philjackson
Copy link
Contributor

I haven't. What would mo-git-blame get us over the built-in vc-annotate?

@voins
Copy link
Contributor

voins commented Jun 7, 2010

Maybe nothing. :) I should look at vc-annotate closer.

@philjackson
Copy link
Contributor

I use vc-annotate, it's pretty nice and would probably be easier to integrate. Up to you though.

@nurpax
Copy link
Author

nurpax commented Jun 7, 2010

Thanks, I'll try vc-annotate. I couldn't get it to work last time I tried:

error: unknown option `-rmaster'
usage: git blame [options] [rev-opts] [rev] [--] file

I don't know whether my git is too new (1.7) or my Emacs too old. But I guess that's out of the scope of this issue tracker. :)

@philjackson
Copy link
Contributor

I'm going to close this, if you don't mind. I think vc-annotate is good enough.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

4 participants