Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Magit additions into Emacs #2933

Closed
1 of 4 tasks
tarsius opened this issue Jan 8, 2017 · 4 comments
Closed
1 of 4 tasks

Get Magit additions into Emacs #2933

tarsius opened this issue Jan 8, 2017 · 4 comments
Labels
. maintainer's bookmark area: emacs
Milestone

Comments

@tarsius
Copy link
Member

tarsius commented Jan 8, 2017

Magit contains some features that should instead be implemented directly in Emacs. This list is not exhaustive, I intend to add to it as I run into more things.

  • Ediff provides two commands for resolving conflicts with the help of some vcs. For each vcs and/or vcs interface some parts have to be implemented separately. The issues are in the common part: most importantly the user has to resolve all conflict, including those that the vcs already resolved successfully. Also see Can Magit be used as ediff-version-control-package?.

  • Emacs provides the option server-window to allow users to customize what function should be used to show the buffer and optionally switch to the used window. But sometimes that isn't enough because a user or package wants to use different function for different files. The with-editor package (which was written for the benefit of Magit and was originally part of it) defines an additional option with-editor-server-window-alist and advices server-switch-buffer to respect that. Emacs should just provide such an option itself.

  • Teach tabulated-list about :help-echo. See magit-repolist-columns: specify help-echo for narrow columns #3233.

  • Fix auth-source bug. See magit/ghub@3ba8646. Done, will be fixed in Emacs 26.2 (emacs-mirror/emacs@5e42c34)

@tarsius tarsius modified the milestones: 3.0.0, maybe Mar 29, 2018
@npostavs
Copy link
Member

npostavs commented Aug 6, 2018

Fix auth-source bug. See magit/ghub@3ba8646.

This one is fixed in emacs-master now (specificallly, emacs-mirror/emacs@60ff810). Do you think it's worth backporting to 26.2?

@tarsius
Copy link
Member Author

tarsius commented Aug 6, 2018

I don't know the policy, but this is clearly a bug and the fix comes with tests and all. I think this should make it into the next release because the fixed issue is rather confusing.

@npostavs
Copy link
Member

I've pushed it to emacs-26 (and updated the OP here).

@tarsius tarsius added the . maintainer's bookmark label Oct 9, 2018
@tarsius
Copy link
Member Author

tarsius commented Oct 9, 2018

I am busy improving magit instead (and already had to extend the "year" of magit to 15 months). Maybe next year...

@tarsius tarsius closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
. maintainer's bookmark area: emacs
Development

No branches or pull requests

2 participants