Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] magit-log-graph face broken #4570

Closed
cstby opened this issue Dec 30, 2021 · 2 comments
Closed

[bug] magit-log-graph face broken #4570

cstby opened this issue Dec 30, 2021 · 2 comments

Comments

@cstby
Copy link

cstby commented Dec 30, 2021

I'm on Magit v3.3.0-73-g03f495f3, Git 2.30.2, Emacs 27.1, gnu/linux. It appears that the face magit-log-graph is not working as expected. I can customize the face, but the log graph does not appear to use this face.

Steps to Reproduce

  • Open a magit status buffer from a local git repo.
  • Show the current log with l l.
  • Call the interactive command list-faces-dislpay
  • Find magit-log-graph and follow the link to the customization window.
  • At the bottom of the window, hit the choose button to select a new foreground color for the magit-log-graph face.
  • Choose any color different from the current one.
  • Hit Apply.

Expected Result

  • The graph in the the magit log should use the newly selected foreground color.

Actual Result

  • The graph color remains unchanged.
@kyleam
Copy link
Member

kyleam commented Dec 30, 2021

The magit-log-graph face is by design only in effect when the --color and --graph switches are specified:

magit/lisp/magit-log.el

Lines 1190 to 1198 in 03f495f

(defun magit-log-wash-log (style args)
(setq args (-flatten args))
(when (and (member "--graph" args)
(member "--color" args))
(let ((ansi-color-apply-face-function
(lambda (beg end face)
(put-text-property beg end 'font-lock-face
(or face 'magit-log-graph)))))
(ansi-color-apply-on-region (point-min) (point-max))))

@cstby
Copy link
Author

cstby commented Dec 31, 2021

Ah, thank you for that clarification. Closing this issue.

@cstby cstby closed this as completed Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants