Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated growth of entering edges looks bad on Chrome & Safari #2

Closed
magjac opened this issue Aug 28, 2017 · 2 comments
Closed

Animated growth of entering edges looks bad on Chrome & Safari #2

magjac opened this issue Aug 28, 2017 · 2 comments
Labels

Comments

@magjac
Copy link
Owner

magjac commented Aug 28, 2017

Some arrowheads have the wrong direction during transitions and the edges are grown i segments. On Firefox is looks good.

The root cause is that the getTotalLength() method is undefined here and the test workaround for jsdom/jsdom#1330 kicks in. Probably this is because the element is part of a DocumentFragment.

@magjac
Copy link
Owner Author

magjac commented Aug 28, 2017

If a DocumentFragment is not used, but the initial SVG is instead created directly in the DOM, the problem does not occur, but this approach may have performance implications.

@magjac magjac closed this as completed in b65fe7e Aug 29, 2017
@magjac
Copy link
Owner Author

magjac commented Aug 29, 2017

There was no measurable performance difference between the DOM and the Document Fragment approach. A few ms for a graph with 20 nodes and 15 edges. The layout and data extraction require magnitudes longer time.

magjac pushed a commit that referenced this issue Feb 10, 2018
This essentially reverts commmit
b65fe7e which was made to fix
#2. However, the real
reason the original solution didn't work in Chrome was that just
setting the innerHTML to a string didn't create a real SVG with
their methods, including the getTotalLength() method.
magjac pushed a commit that referenced this issue Feb 17, 2018
This essentially reverts commmit
b65fe7e which was made to fix
#2. However, the real
reason the original solution didn't work in Chrome was that just
setting the innerHTML to a string didn't create a real SVG XML
document with its methods, including the getTotalLength() method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant