Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The layout engine cannot be changed between two graph renderings #79

Closed
magjac opened this issue Jul 14, 2018 · 0 comments
Closed

The layout engine cannot be changed between two graph renderings #79

magjac opened this issue Jul 14, 2018 · 0 comments

Comments

@magjac
Copy link
Owner

magjac commented Jul 14, 2018

If an attempt to change the layout engine is made after rendering the first graph, d3-graphviz throws Error: Too late to change engine.

Although this implementation was intentional and aimed at informing the user that a change of the layout engine between a call to graphviz.dot and graphviz.render had no effect, it was a bad idea since it prohibits transitions between two graphs rendered with different layout engines.

Rather than throwing an error, such a change should be allowed and its effect properly documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant