Skip to content

Commit

Permalink
chore: Address or remove all TODOs assigned to themarwhal
Browse files Browse the repository at this point in the history
Signed-off-by: GitHub <noreply@github.com>
  • Loading branch information
themarwhal committed Apr 28, 2022
1 parent ca545de commit 410d7c0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
5 changes: 2 additions & 3 deletions lte/gateway/c/session_manager/ChargingGrant.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,8 @@ CreditValidity ChargingGrant::get_credit_response_validity_type(
!gsu.total().is_valid() && !gsu.rx().is_valid() && !gsu.tx().is_valid();
if (gsu_all_invalid) {
if (update.credit().is_final() || credit_validity == TRANSIENT_ERROR) {
// TODO(@themarwhal): look into this case. Before I figure it out, I will
// allow empty GSU credits with FUA or to be suspended
// to be on the conservative side.
// We will allow empty GSU credits with FUA or to be suspended
// to be on the conservative side
MLOG(MWARNING)
<< "GSU for RG: " << key << " " << session_id
<< " is invalid, but accepting it as it has a final unit action or "
Expand Down
2 changes: 0 additions & 2 deletions lte/gateway/c/session_manager/SessionState.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ const char* LABEL_SESSION_ID = "session_id";
const char* LABEL_DIRECTION = "direction";
const char* DIRECTION_UP = "up";
const char* DIRECTION_DOWN = "down";
// TODO(@themarwhal): SessionD should own the naming of the drop all rule so
// that we never regress here
const char* DROP_ALL_RULE = "internal_default_drop_flow_rule";
} // namespace

Expand Down
2 changes: 1 addition & 1 deletion lte/gateway/c/session_manager/SessionState.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ class SessionState {
bool add_to_monitor(const std::string& key, uint64_t used_tx,
uint64_t used_rx, SessionStateUpdateCriteria* session_uc);

// TODO(@themarwhal) clean up this function as it is used for testing only
// TODO #12593 clean up this function as it is used for testing only
void set_monitor(const std::string& key, Monitor monitor,
SessionStateUpdateCriteria* session_uc);

Expand Down

0 comments on commit 410d7c0

Please sign in to comment.