chore(agw): Bazelify test_s1ap_mme_handlers_with_injected_state (#13334)

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
magma · Jul 25, 2022 · 6f443cc · 6f443cc
1 parent 53a453f
commit 6f443cc
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 6 deletions.
diff --git a/bazel/scripts/check_c_cpp_bazel.sh b/bazel/scripts/check_c_cpp_bazel.sh
@@ -40,10 +40,6 @@ DENY_LIST_NOT_YET_BAZELIFIED=(
   # TODO: GH12771 add MME_BENCHMARK support and bazelify files
   "./lte/gateway/c/core/oai/tasks/mme_app/experimental/mme_app_serialization.hpp"
   "./lte/gateway/c/core/oai/tasks/mme_app/experimental/mme_app_serialization.cpp"
-  # TODO: GH12775 tests that need to be bazelified
-  "./lte/gateway/c/core/oai/test/s1ap_task/mock_s1ap_op.h"
-  "./lte/gateway/c/core/oai/test/s1ap_task/mock_s1ap_op.cpp"
-  "./lte/gateway/c/core/oai/test/s1ap_task/test_s1ap_mme_handlers_with_injected_state.cpp"
 )
 
 DENY_LIST=( "${DENY_LIST_NOT_RELEVANT[@]}" "${DENY_LIST_NOT_YET_BAZELIFIED[@]}" )

diff --git a/lte/gateway/c/core/oai/test/s1ap_task/BUILD.bazel b/lte/gateway/c/core/oai/test/s1ap_task/BUILD.bazel
@@ -76,3 +76,29 @@ cc_test(
         "@com_google_googletest//:gtest_main",
     ],
 )
+
+cc_library(
+    name = "mock_s1ap_op",
+    testonly = True,
+    srcs = ["mock_s1ap_op.cpp"],
+    hdrs = ["mock_s1ap_op.h"],
+    deps = [
+        "//lte/gateway/c/core:lib_agw_of",
+        "//lte/gateway/c/core/common:common_defs",
+    ],
+)
+
+cc_test(
+    name = "s1ap_mme_handlers_with_injected_state_test",
+    size = "small",
+    srcs = ["test_s1ap_mme_handlers_with_injected_state.cpp"],
+    deps = [
+        ":mock_s1ap_op",
+        ":s1ap_mme_test_utils",
+        "//lte/gateway/c/core:lib_agw_of",
+        "//lte/gateway/c/core/common:dynamic_memory_check",
+        "//lte/gateway/c/core/oai/lib/bstr:bstrlib",
+        "//lte/gateway/c/core/oai/test/mock_tasks",
+        "@com_google_googletest//:gtest_main",
+    ],
+)
diff --git a/lte/gateway/c/core/oai/test/s1ap_task/s1ap_mme_test_utils.cpp b/lte/gateway/c/core/oai/test/s1ap_task/s1ap_mme_test_utils.cpp
@@ -31,7 +31,7 @@ extern "C" {
 namespace magma {
 namespace lte {
 
-extern task_zmq_ctx_t task_zmq_ctx_main_s1ap;
+task_zmq_ctx_t task_zmq_ctx_main_s1ap;
 
 status_code_e setup_new_association(s1ap_state_t* state,
                                     sctp_assoc_id_t assoc_id) {

diff --git a/lte/gateway/c/core/oai/test/s1ap_task/test_s1ap_mme_handlers.cpp b/lte/gateway/c/core/oai/test/s1ap_task/test_s1ap_mme_handlers.cpp
@@ -36,7 +36,7 @@ extern task_zmq_ctx_t task_zmq_ctx_mme;
 namespace magma {
 namespace lte {
 
-task_zmq_ctx_t task_zmq_ctx_main_s1ap;
+extern task_zmq_ctx_t task_zmq_ctx_main_s1ap;
 
 static int handle_message(zloop_t* loop, zsock_t* reader, void* arg) {
   MessageDef* received_message_p = receive_msg(reader);