Addressed review comment (R1)

Signed-off-by: RahulKalsangra <rahul.kalsangra@wavelabs.ai>
magma · Mar 16, 2022 · ac46c8f · ac46c8f
1 parent 5aff136
commit ac46c8f
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/lte/gateway/c/core/oai/tasks/amf/amf_authentication.cpp b/lte/gateway/c/core/oai/tasks/amf/amf_authentication.cpp
@@ -129,8 +129,8 @@ static int start_authentication_information_procedure(
 }
 
 int amf_authentication_request_sent(amf_ue_ngap_id_t ue_id) {
-  ue_m5gmm_context_s* ue_mm_context = NULL;
-  amf_context_t* amf_context = NULL;
+  ue_m5gmm_context_s* ue_mm_context = nullptr;
+  amf_context_t* amf_context = nullptr;
   char imsi_str[IMSI_BCD_DIGITS_MAX + 1];
   int rc = RETURNerror;
   ue_mm_context = amf_ue_context_exists_amf_ue_ngap_id(ue_id);

diff --git a/lte/gateway/c/core/oai/tasks/amf/nas_proc.cpp b/lte/gateway/c/core/oai/tasks/amf/nas_proc.cpp
@@ -416,11 +416,11 @@ int amf_nas_proc_auth_param_res(amf_ue_ngap_id_t amf_ue_ngap_id,
 
 static int subs_auth_retry(zloop_t* loop, int timer_id, void* arg) {
   amf_ue_ngap_id_t ue_id = 0;
-  amf_context_t* amf_ctxt_p = NULL;
+  amf_context_t* amf_ctxt_p = nullptr;
   int amf_cause = -1;
-  nas5g_auth_info_proc_t* auth_info_proc = NULL;
+  nas5g_auth_info_proc_t* auth_info_proc = nullptr;
   int rc = RETURNerror;
-  ue_m5gmm_context_s* ue_mm_context = NULL;
+  ue_m5gmm_context_s* ue_mm_context = nullptr;
   if (!amf_pop_timer_arg(timer_id, &ue_id)) {
     OAILOG_WARNING(
         LOG_AMF_APP,

diff --git a/lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp b/lte/gateway/c/core/oai/test/amf/test_amf_procedures.cpp
@@ -1694,8 +1694,8 @@ TEST_F(AMFAppProcedureTest, ServiceRequestSignalling) {
 
 TEST_F(AMFAppProcedureTest, TestAuthFailureFromSubscribeDbLock) {
   amf_ue_ngap_id_t ue_id = 0;
-  amf_context_t* amf_ctxt_p = NULL;
-  nas5g_auth_info_proc_t* auth_info_proc = NULL;
+  amf_context_t* amf_ctxt_p = nullptr;
+  nas5g_auth_info_proc_t* auth_info_proc = nullptr;
   ue_m5gmm_context_s* ue_context_p = nullptr;
   std::vector<MessagesIds> expected_Ids{
       AMF_APP_NGAP_AMF_UE_ID_NOTIFICATION,  // new registration notification

diff --git a/lte/gateway/python/scripts/generate_oai_config.py b/lte/gateway/python/scripts/generate_oai_config.py
@@ -334,7 +334,9 @@ def _get_amf_name_config(service_mconfig: object) -> str:
 
 
 def _get_default_auth_retry_count(service_mconfig: object) -> str:
-    """Retrieve default_auth_retry_count config value. If it does not exist, it defaults to DEFAULT_AUTH_RETRY_COUNT.
+    """
+    Retrieve default_auth_retry_count config value. If it does not
+    exist, it defaults to DEFAULT_AUTH_RETRY_COUNT.
 
     Args:
         service_mconfig: This is a configuration placeholder for mme.
@@ -353,7 +355,9 @@ def _get_default_auth_retry_count(service_mconfig: object) -> str:
 
 
 def _get_default_auth_timer_expire_msec(service_mconfig: object) -> str:
-    """Retrieve default_auth_retry_timer_expire_msec config value. If it does not exist, it defaults to DEFAULT_AUTH_TIMER_EXPIRE_MSEC.
+    """
+    Retrieve default_auth_retry_timer_expire_msec config value. If it
+    does not exist, it defaults to DEFAULT_AUTH_TIMER_EXPIRE_MSEC.
 
     Args:
         service_mconfig: This is a configuration placeholder for mme.