-
Notifications
You must be signed in to change notification settings - Fork 590
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(orc8r): Split Metricsd to protected and southbound
Signed-off-by: Christine Wang <christinewang@fb.com>
- Loading branch information
1 parent
8d9987f
commit b0b967e
Showing
9 changed files
with
364 additions
and
321 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
140 changes: 140 additions & 0 deletions
140
orc8r/cloud/go/services/metricsd/servicers/protected/servicer_protected_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,140 @@ | ||
| /* | ||
| Copyright 2020 The Magma Authors. | ||
| This source code is licensed under the BSD-style license found in the | ||
| LICENSE file in the root directory of this source tree. | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package protected | ||
|
|
||
| import ( | ||
| "context" | ||
| "flag" | ||
| "strconv" | ||
| "testing" | ||
| "time" | ||
|
|
||
| dto "github.com/prometheus/client_model/go" | ||
| prometheusProto "github.com/prometheus/client_model/go" | ||
| "github.com/stretchr/testify/assert" | ||
|
|
||
| configurator_test_init "magma/orc8r/cloud/go/services/configurator/test_init" | ||
| configurator_test_utils "magma/orc8r/cloud/go/services/configurator/test_utils" | ||
| device_test_init "magma/orc8r/cloud/go/services/device/test_init" | ||
| "magma/orc8r/cloud/go/services/metricsd/exporters" | ||
| tests "magma/orc8r/cloud/go/services/metricsd/test_common" | ||
| "magma/orc8r/cloud/go/services/metricsd/test_init" | ||
| "magma/orc8r/lib/go/metrics" | ||
| "magma/orc8r/lib/go/protos" | ||
| ) | ||
|
|
||
| var ( | ||
| testLabels = []*prometheusProto.LabelPair{{Name: tests.MakeStrPtr("labelName"), Value: tests.MakeStrPtr("labelValue")}} | ||
| ) | ||
|
|
||
| // Set verbosity so we can capture exporter error logging | ||
| var _ = flag.Set("vmodule", "*=2") | ||
|
|
||
| func TestPreprocessCloudMetrics(t *testing.T) { | ||
| testFamily := tests.MakeTestMetricFamily(prometheusProto.MetricType_GAUGE, 1, testLabels) | ||
| metricAndContext := preprocessCloudMetrics(testFamily, "hostA") | ||
|
|
||
| assert.NotNil(t, metricAndContext.Context.AdditionalContext) | ||
| assert.Equal(t, "hostA", metricAndContext.Context.AdditionalContext.(*exporters.CloudMetricContext).CloudHost) | ||
|
|
||
| labels := metricAndContext.Family.GetMetric()[0].Label | ||
| assert.Equal(t, 2, len(labels)) | ||
| assert.True(t, tests.HasLabel(labels, "cloudHost", "hostA")) | ||
| assert.True(t, tests.HasLabel(labels, testLabels[0].GetName(), testLabels[0].GetValue())) | ||
| } | ||
|
|
||
| func TestPushedMetricsToMetricsAndContext(t *testing.T) { | ||
| container := protos.PushedMetricsContainer{ | ||
| NetworkId: "testNetwork", | ||
| Metrics: []*protos.PushedMetric{{ | ||
| MetricName: "metricA", | ||
| Value: 10, | ||
| TimestampMS: 1234, | ||
| Labels: []*protos.LabelPair{{Name: "labelName", Value: "labelValue"}}, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| metricAndContext := pushedMetricsToMetricsAndContext(&container) | ||
|
|
||
| assert.Equal(t, 1, len(metricAndContext)) | ||
| ctx := metricAndContext[0].Context | ||
| family := metricAndContext[0].Family | ||
| assert.NotNil(t, ctx.AdditionalContext) | ||
| assert.Equal(t, "testNetwork", ctx.AdditionalContext.(*exporters.PushedMetricContext).NetworkID) | ||
|
|
||
| labels := family.GetMetric()[0].Label | ||
| assert.Equal(t, 2, len(labels)) | ||
| assert.True(t, tests.HasLabel(labels, metrics.NetworkLabelName, "testNetwork")) | ||
| assert.True(t, tests.HasLabel(labels, "labelName", "labelValue")) | ||
| } | ||
|
|
||
| func TestConsume(t *testing.T) { | ||
| metricsChan := make(chan *dto.MetricFamily) | ||
| e := &exporters.TestMetricExporter{} | ||
|
|
||
| test_init.StartNewTestExporter(t, e) | ||
| srv := NewCloudMetricsControllerServer() | ||
|
|
||
| go srv.ConsumeCloudMetrics(metricsChan, "Host_name_place_holder") | ||
| fam1 := "test1" | ||
| fam2 := "test2" | ||
| go func() { | ||
| metricsChan <- &dto.MetricFamily{Name: &fam1, Metric: []*dto.Metric{{}}} | ||
| metricsChan <- &dto.MetricFamily{Name: &fam2, Metric: []*dto.Metric{{}}} | ||
| }() | ||
| time.Sleep(time.Second) | ||
| assert.Equal(t, 2, len(e.Queue)) | ||
| } | ||
|
|
||
| func TestPush(t *testing.T) { | ||
| device_test_init.StartTestService(t) | ||
| configurator_test_init.StartTestService(t) | ||
|
|
||
| e := &exporters.TestMetricExporter{} | ||
| test_init.StartNewTestExporter(t, e) | ||
| srv := NewCloudMetricsControllerServer() | ||
|
|
||
| // Create test network | ||
| networkID := "metricsd_servicer_test_network" | ||
| configurator_test_utils.RegisterNetwork(t, networkID, "Test Network Name") | ||
|
|
||
| metricName := "test_metric" | ||
| value := 8.2 | ||
| testLabel := &protos.LabelPair{Name: "labelName", Value: "labelValue"} | ||
| timestamp := int64(123456) | ||
|
|
||
| protoMet := protos.PushedMetric{ | ||
| MetricName: metricName, | ||
| Value: value, | ||
| TimestampMS: timestamp, | ||
| Labels: []*protos.LabelPair{testLabel}, | ||
| } | ||
| pushedMetrics := protos.PushedMetricsContainer{ | ||
| NetworkId: networkID, | ||
| Metrics: []*protos.PushedMetric{&protoMet}, | ||
| } | ||
|
|
||
| _, err := srv.Push(context.Background(), &pushedMetrics) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, 1, len(e.Queue)) | ||
| assert.Equal(t, metricName, e.Queue[0].Name()) | ||
| assert.Equal(t, 2, len(e.Queue[0].Labels())) | ||
| assert.Equal(t, testLabel.Name, *e.Queue[0].Labels()[0].Name) | ||
| assert.Equal(t, testLabel.Value, *e.Queue[0].Labels()[0].Value) | ||
| assert.Equal(t, metrics.NetworkLabelName, *e.Queue[0].Labels()[1].Name) | ||
| assert.Equal(t, networkID, *e.Queue[0].Labels()[1].Value) | ||
| assert.Equal(t, timestamp, e.Queue[0].TimestampMs()) | ||
| assert.Equal(t, strconv.FormatFloat(value, 'f', -1, 64), e.Queue[0].Value()) | ||
| } |
Oops, something went wrong.