Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move python module code to script folders #12754

Open
vktng opened this issue May 17, 2022 · 1 comment · Fixed by #12773
Open

Move python module code to script folders #12754

vktng opened this issue May 17, 2022 · 1 comment · Fixed by #12773
Labels
bazel changes for the Bazelification effort bazel-cleanup BE fixups that came out of the Bazelification effort willfix This will be worked on and shouldn't be reaped

Comments

@vktng
Copy link
Contributor

vktng commented May 17, 2022

Python files that are not used in the modules they are defined in should be moved to the respective script folders: (lte|orc8r)/gateway/python/scripts/
This includes:

  • "./orc8r/gateway/python/magma/common/health/docker_health_service.py"
  • "./orc8r/gateway/python/magma/common/health/health_service.py"
  • "./orc8r/gateway/python/magma/common/health/entities.py"
  • "./lte/gateway/python/magma/health/health_service.py"
  • "./lte/gateway/python/magma/health/entities.py"
  • "./lte/gateway/python/magma/pipelined/pg_set_session_msg.py"
@vktng vktng added bazel-cleanup BE fixups that came out of the Bazelification effort willfix This will be worked on and shouldn't be reaped labels May 17, 2022
@jheidbrink jheidbrink linked a pull request May 18, 2022 that will close this issue
chore(agw): Move script-only dependencies to scripts folders #12773
Merged
This was referenced Jul 5, 2022
Closed
Merged
@nstng nstng reopened this Jul 5, 2022
@nstng
Copy link
Contributor

nstng commented Jul 5, 2022

Reopened - needs to be revised. Current approach reverted in #13191

@MoritzThomasHuebner MoritzThomasHuebner mentioned this issue Dec 22, 2022
Merged
2 tasks
@nstng nstng added the bazel changes for the Bazelification effort label Dec 27, 2022
@LKreutzer LKreutzer reopened this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bazel changes for the Bazelification effort bazel-cleanup BE fixups that came out of the Bazelification effort willfix This will be worked on and shouldn't be reaped
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(agw): Move script-only dependencies to scripts folders jheidbrink/magma
4 participants
@mpfirrmann @LKreutzer @nstng @vktng