Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(agw): Move script-only dependencies to scripts folders (#12773)" #13191

Merged
merged 1 commit into from Jul 8, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Jul 5, 2022

This reverts commit 059393d.

Summary

See #13190.

Problem

Solution Here

Test Plan

In magma VM

  • ~/magma/lte/gateway $ ./release/build-magma.sh -h 123 --commit-count 23 -t RelWithDebInfo --cert $MAGMA_ROOT/.cache/test_certs/rootCA.pem --proxy $MAGMA_ROOT/lte/gateway/configs/control_proxy.yml --os ubuntu
  • move magma_1.8.0-1657013498-123_amd64.deb (timestamp will vary) to a VM where magma can be installed

In Install VM

  • sudo apt install ./magma_1.8.0-1657013498-123_amd64.deb
  • execute health_cli.py or agw_health_cli.py
  • see that ModuleNotFoundError on scripts is not raised

NOTE

Additional Information

  • This change is backwards-breaking

@nstng nstng requested review from a team July 5, 2022 10:13
@nstng nstng requested a review from a team as a code owner July 5, 2022 10:13
@nstng nstng requested review from a team, vktng and ajahl July 5, 2022 10:13
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Jul 5, 2022
@nstng nstng requested a review from uri200 July 5, 2022 10:13
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: orc8r Orchestrator-related issue labels Jul 5, 2022
@nstng nstng linked an issue Jul 5, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit a0f625b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

dp-workflow

18 tests   18 ✔️  4m 21s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit a0f625b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

cloud-workflow

990 tests   990 ✔️  2m 17s ⏱️
355 suites      0 💤
    7 files        0

Results for commit a0f625b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

agw-workflow

580 tests   576 ✔️  6m 30s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit a0f625b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@LKreutzer LKreutzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I restarted the failed agw-workflow (it was the flaky mme test 11).

@nstng nstng requested review from pshelar and removed request for vktng July 5, 2022 11:30
…agma#12773)"

This reverts commit 059393d.

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@nstng nstng force-pushed the fix_deb_script_module_path branch from 0dc01f6 to a0f625b Compare July 7, 2022 10:04
@maxhbr maxhbr merged commit a5d9afa into magma:master Jul 8, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…agma#12773)" (magma#13191)

This reverts commit 059393d.

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue component: orc8r Orchestrator-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Script Module Path is Fixed
5 participants