New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "chore(agw): Move script-only dependencies to scripts folders (#12773)" #13191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
Access gateway-related issue
component: orc8r
Orchestrator-related issue
labels
Jul 5, 2022
sebathomas
approved these changes
Jul 5, 2022
LKreutzer
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. I restarted the failed agw-workflow (it was the flaky mme test 11).
ajahl
approved these changes
Jul 5, 2022
…agma#12773)" This reverts commit 059393d. Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
nstng
force-pushed
the
fix_deb_script_module_path
branch
from
July 7, 2022 10:04
0dc01f6
to
a0f625b
Compare
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
…agma#12773)" (magma#13191) This reverts commit 059393d. Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: agw
Access gateway-related issue
component: orc8r
Orchestrator-related issue
size/M
Denotes a PR that changes 30-99 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 059393d.
Summary
See #13190.
Problem
Solution Here
Test Plan
In magma VM
~/magma/lte/gateway $ ./release/build-magma.sh -h 123 --commit-count 23 -t RelWithDebInfo --cert $MAGMA_ROOT/.cache/test_certs/rootCA.pem --proxy $MAGMA_ROOT/lte/gateway/configs/control_proxy.yml --os ubuntu
magma_1.8.0-1657013498-123_amd64.deb
(timestamp will vary) to a VM where magma can be installedIn Install VM
sudo apt install ./magma_1.8.0-1657013498-123_amd64.deb
health_cli.py
oragw_health_cli.py
scripts
is not raisedNOTE
sudo apt install python3-docker
Additional Information