Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subscriberdb] Subscribers not showing up after IMSI deconcealing fix (12567) #13036

Closed
vroon2703 opened this issue Jun 20, 2022 · 4 comments
Closed
Assignees
Labels
product: 5g sa type: bug Something isn't working

Comments

@vroon2703
Copy link
Contributor

vroon2703 commented Jun 20, 2022

Your Environment

  • Version: master
  • Affected Component: Access Gateway
  • Affected Subcomponent: SubscriberDB
  • Deployment Environment: Vagrant (AGW)

Describe the Issue

Possibly related commit: #12567

After adding a new subscriber via swagger and running subscriber_cli.py list on the gateway VM returns no subscribers. The debug logs indicate the following error:

ERROR:root:Fetch suci profiles error! [StatusCode.UNKNOWN] handler panic: runtime error: invalid memory address or nil pointer dereference;

To Reproduce

  1. Add a subscriber using Swagger (/lte/{network_id}/subscribers)
  2. On the AGW VM, run subscriber_cli.py list
  3. Observe that the added subscriber does not show up.
  4. Run sudo journalctl -u magma@subscriberdb to see the logs

Expected behavior
IMSI of the added subscriber shows up.

Screenshots
GET shows that IMSI has been added.
Screen Shot 2022-06-20 at 3 52 36 PM

subscriber_cli.py list does not print any IMSIs
Screen Shot 2022-06-20 at 3 53 18 PM

Error message shows up: fetch suci profiles error!

Screen Shot 2022-06-20 at 3 57 17 PM 1

@vroon2703 vroon2703 added the type: bug Something isn't working label Jun 20, 2022
@ssanadhya ssanadhya changed the title Subscribers not showing up after IMSI deconcealing fix (12567) [subscriberdb] Subscribers not showing up after IMSI deconcealing fix (12567) Jun 21, 2022
@Akshayp77
Copy link
Contributor

On latest master code base, we have added a new subscriber(IMSI001010000000004) through swagger API and it is getting reflected only after 5 minutes in the subscriberdb. Please refer attached log file and snapshots.
sys-subdb.log

Screenshot (27)
Screenshot (28)
Screenshot (29)
Screenshot (30)

@sebathomas
Copy link
Contributor

sebathomas commented Jun 23, 2022

I see the error on my laptop as well and I'm not sure it's caused by the changes from #12567. It seems like it's somewhere in the orc8r, and the PR mostly touched agw code.
It might be the change of the proto file though.

The orc8r subscriberdb panics because of a nil pointer access in this line:

suciProfiles := ngcConfig.(*lte_models.NetworkNgcConfigs).SuciProfiles

@sebathomas
Copy link
Contributor

sebathomas commented Jun 23, 2022

Okay, the nil check is broken there, you have to do the type conversion before the check. Will add a PR to fix that so subscriberdb returns an error instead of panicking.

LoadSuciProtos will still fail because ngcConfig is null though.

See #13065.

@panyogesh
Copy link
Contributor

Closing the ticket with reference to #13081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: 5g sa type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants