feat(subscriberdb): Handle NW NGC config nil check correctly #13081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moinuddin1980
added
component: orc8r
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
moinuddin1980
force-pushed
the
regression-13036
branch
from
1adf1f5
to
f060859
Compare
moinuddin1980
force-pushed
the
regression-13036
branch
from
f060859
to
7189f05
Compare
sebathomas
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Looking good, I think this will fix the issue, I just wonder if we can make it a bit more stable.
In the Python client on the gateway, we currently fetch the suci profiles first and skip all other sync calls if the suci call fails. See client.py. Would it be better to do the suci call last? At the moment, the response doesn't seem to be used in the client.
moinuddin1980
force-pushed
the
regression-13036
branch
from
7189f05
to
492c05a
Compare
sebathomas
approved these changes
Jun 28, 2022
moinuddin1980
force-pushed
the
regression-13036
branch
2 times, most recently
from
b59952e
to
8afa51f
Compare
Signed-off-by: Moinuddin Khan <moinuddin.khan@wavelabs.ai>
moinuddin1980
force-pushed
the
regression-13036
branch
from
8afa51f
to
d331f8e
Compare
pull-request-size
bot
added
size/M
sebathomas
approved these changes
Jul 5, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
…3081) Signed-off-by: Moinuddin Khan <moinuddin.khan@wavelabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Moinuddin Khan moinuddin.khan@wavelabs.ai
feat(subscriberdb): Handle NW NGC config nil check correctly
Summary
Done the following as part of the PR:
Test Plan
Tested in local VM using docker based Orc8r and AGW.
Additional Information
#13036