Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfolly-dev build for arm is fixed #14358

Open
nstng opened this issue Nov 4, 2022 · 1 comment
Open

libfolly-dev build for arm is fixed #14358

nstng opened this issue Nov 4, 2022 · 1 comment
Labels
bazel-cleanup BE fixups that came out of the Bazelification effort

Comments

@nstng
Copy link
Contributor

nstng commented Nov 4, 2022

in order to install libfolly-dev on a docker container, in #13741 sudo was removed from the post install script in the third-party build. The lib was only re-build for amd64 and published to the artifactory - this is missing for arm. Consequence is that the bazel base and devcontainer can not be create on arm.

The build is currently not working on arm - a quick fix was not found yet.

third_party/build $ ./build.py folly
[..]
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) none
checking if g++ supports C++1y features without additional flags... no
checking if g++ supports C++1y features with -std=c++1y... no
checking if g++ supports C++1y features with -std=gnu++1y... no
configure: error: Could not find cxx1y support in g++
Traceback (most recent call last):
  File "./build.py", line 193, in <module>
    main(args)
  File "./build.py", line 181, in main
    build(package, env=env, install=not args.no_install)
  File "./build.py", line 109, in build
    subprocess.run([script], check=True, env=env)
  File "/usr/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['./bin/folly_build.sh']' returned non-zero exit status 1.
@nstng
Copy link
Contributor Author

nstng commented Nov 4, 2022

@m-govind do you have a hint here? I see that you uploaded the last libfolly-dev arm artifact - did you encounter an issue like in the description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel-cleanup BE fixups that came out of the Bazelification effort
Projects
None yet
Development

No branches or pull requests

1 participant