fix: folly can be installed on systems without sudo #13741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com
Summary
The pre-build folly library can not be installed on docker environments without sudo - the post install script executeds
sudo ldconfig
. The sudo is unnecessary as post install scripts are always executed as root.This change updates the build script that was used to create the attached library. The library needs to be uploaded to focal-ci after this PR is merged.
folly.zip
-> uploaded to focal-ci 2022-08-25
Test Plan
~/magma/third_party/build$ ./build.py folly
bazel test ...
)Additional Information