Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: folly can be installed on systems without sudo #13741

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Aug 25, 2022

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

The pre-build folly library can not be installed on docker environments without sudo - the post install script executeds sudo ldconfig. The sudo is unnecessary as post install scripts are always executed as root.

This change updates the build script that was used to create the attached library. The library needs to be uploaded to focal-ci after this PR is merged.
folly.zip

-> uploaded to focal-ci 2022-08-25

Test Plan

  • build library on magma vm (takes some time): ~/magma/third_party/build$ ./build.py folly
  • current library can not be installed in the bazel base container
  • new library can be installed in bazel build container and bazel build still works (tested for bazel test ...)

Additional Information

  • This change is backwards-breaking

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@nstng nstng requested a review from a team as a code owner August 25, 2022 17:09
@nstng nstng requested a review from tmdzk August 25, 2022 17:09
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Aug 25, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 25, 2022
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 800f1d4.

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nstng nstng merged commit 0ef8aba into magma:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants