Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nms): Upgrade json-server from 0.16.0 to 0.17.0 #11326

Closed
wants to merge 1 commit into from

Conversation

nikolakn
Copy link
Contributor

@nikolakn nikolakn commented Jan 31, 2022

Signed-off-by: Nikola Knezevic nkcodeplus@gmail.com
chore(nms): Upgrade json-server from 0.16.0 to 0.17.0

Summary

Dependabot didn't succeed in automatically updating dependency for nonoid is required by json-server": "^0.16.1" there is version 0.17.0 that depend on "nanoid": "^3.1.23"
https://github.com/ospoco/magma-issue-tracker/issues/57
solution: update json-server to 0.17.0 and test

Test Plan

yarn run eslint
yarn run flow
yarn run test

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 31, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label Jan 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022

nms-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 26e25b9.

♻️ This comment has been updated with latest results.

Signed-off-by: Nikola Knezevic <nkcodeplus@gmail.com>
@nikolakn nikolakn marked this pull request as ready for review January 31, 2022 14:39
@nikolakn nikolakn requested review from a team, andreilee and karthiksubraveti and removed request for andreilee January 31, 2022 14:39
@nikolakn nikolakn changed the title chore(nms): Upgrade son-server from 0.16.0 to 0.17.0 chore(nms): Upgrade json-server from 0.16.0 to 0.17.0 Feb 1, 2022
Copy link
Contributor

@andreilee andreilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock should also be updated

@nikolakn nikolakn closed this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants