Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nms): Rename master portal to host portal #11374

Merged
merged 1 commit into from Mar 29, 2022
Merged

fix(nms): Rename master portal to host portal #11374

merged 1 commit into from Mar 29, 2022

Conversation

andreilee
Copy link
Contributor

@andreilee andreilee commented Feb 2, 2022

Signed-off-by: Andrei Lee andreilee@fb.com

Summary

Renaming 'master' portal to 'host' portal, and renaming 'master' organization to 'host' organization.

Test Plan

Verified that db migration occurs automatically.
Example query validating changes after migration:

nms=# select * from "Users" where email = 'admin@magma.test';
 id |      email       | organization |                           password                           | role | networkIDs |  tabs   |       createdAt        |         updatedAt
----+------------------+--------------+--------------------------------------------------------------+------+------------+---------+------------------------+----------------------------
 13 | admin@magma.test | magma-test   | $2a$10$WIAMt3wzGW1VSVu72rIR0eedqM2QESRwD.5CkM2T2vkikfr3saiLu |    3 | []         | ["nms"] | 2021-04-15 21:23:52+00 | 2022-01-18 21:40:50.802+00
 14 | admin@magma.test | host         | $2a$10$9ExoS4Eg9WgScrumWDKEwOKDrJT81kSmc9uhH8QQHGlLzq8X3zoB. |    3 | []         | ["nms"] | 2021-04-15 21:23:55+00 | 2022-01-18 21:40:53.284+00
(2 rows)

nms=# select * from "Organizations" where name = 'host';
 id | name |   tabs    | csvCharset | customDomains | networkIDs | ssoSelectedType | ssoCert | ssoEntrypoint | ssoIssuer | ssoOidcClientID | ssoOidcClientSecret | ssoOidcConfigurationURL |       createdAt        |       updatedAt
----+------+-----------+------------+---------------+------------+-----------------+---------+---------------+-----------+-----------------+---------------------+-------------------------+------------------------+------------------------
  1 | host | ["admin"] |            | []            | []         | none            |         |               |           |                 |                     |                         | 2019-02-11 20:05:05+00 | 2019-02-11 20:05:05+00
(1 row)

nms=# select * from "Organizations" where name = 'master';
 id | name | tabs | csvCharset | customDomains | networkIDs | ssoSelectedType | ssoCert | ssoEntrypoint | ssoIssuer | ssoOidcClientID | ssoOidcClientSecret | ssoOidcConfigurationURL | createdAt | updatedAt
----+------+------+------------+---------------+------------+-----------------+---------+---------------+-----------+-----------------+---------------------+-------------------------+-----------+-----------
(0 rows)

Then visited http://host.magma-test.localhost:8081/host/users to check that the now "Host" portal loads correctly.

Also checked that the NMS and admin portals still load.

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Feb 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label Feb 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

nms-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 33379d8.

♻️ This comment has been updated with latest results.

@stale
Copy link

stale bot commented Mar 19, 2022

This pull request has been automatically marked as stale because it has not had any recent activity by the author or maintainer in the past 45 days. It will be closed if no further activity occurs in the next 7 days. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 19, 2022
@pull-request-size pull-request-size bot added size/XXL Denotes a Pull Request that changes 1000+ lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Mar 22, 2022
@stale stale bot removed the wontfix This will not be worked on label Mar 22, 2022
@andreilee andreilee marked this pull request as ready for review March 22, 2022 04:49
@andreilee andreilee requested review from a team and HannaFar March 22, 2022 04:49
Signed-off-by: Andrei Lee <andreilee@fb.com>
@andreilee andreilee merged commit 69c87be into magma:master Mar 29, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Andrei Lee <andreilee@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/XXL Denotes a Pull Request that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants