feat(nms): Enable federation mapping configuration capability on federated LTE networks #11952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XL
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
thmsschmitt
reviewed
Apr 12, 2022
nms/packages/magmalte/app/views/equipment/FEGGatewayDetailConfig.js
Outdated
Show resolved
Hide resolved
nms/packages/magmalte/app/views/network/NetworkFederationConfig.js
Outdated
Show resolved
Hide resolved
nms/packages/magmalte/app/views/network/NetworkFederationConfig.js
Outdated
Show resolved
Hide resolved
|
Looks good to me, but the tests need to be adapted https://github.com/magma/magma/runs/5415473763?check_suite_focus=true |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const classes = useStyles(); | ||
| const {values} = props; | ||
| const onChange = field => event => | ||
| // $FlowFixMe Set state for each field |
There was a problem hiding this comment.
Unexpected '$FlowFixMe' comment: '$FlowFixMe Set state for each field'.
| @@ -54,6 +55,8 @@ export default function FEGGatewayConfig() { | |||
| const ctx = useContext(FEGGatewayContext); | |||
| const gwInfo: federation_gateway = ctx.state[gatewayId]; | |||
|
|
|||
| console.log('gwInfo:', gwInfo); | |||
There was a problem hiding this comment.
Unexpected console statement.
thmsschmitt
approved these changes
Jun 23, 2022
Signed-off-by: Andrei Lee <andreilee@fb.com>
Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
…rated LTE networks (magma#11952) * feat(nms): Add federated mode mapping capability Signed-off-by: Andrei Lee <andreilee@fb.com> * feat(nms): Only show federation tab for FEG_LTE networks Signed-off-by: Thomas Schmitt <thomas.schmitt@tngtech.com> Co-authored-by: Thomas Schmitt <thomas.schmitt@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This bridges a gap in feature parity between the Orc8r API and NMS.
Enables the ability to configure routing for a federated LTE network, as specified here.
This screenshot shows the addition of additional configuration displayed in the network page for a federated LTE network, specifically "Federated Mapping Mode"
Clicking the "Edit" button, opens up a modal for configuring the federated LTE network. A new tab has been added, labeled "Federation":
There is also the capability to configure the routing/mappings for federation purposes:
Test Plan
Checked enabling/disabling mapping mode
Checked adding/editing/deleting mappings, and persistence across page refreshes, and consistency with direct access through Orc8r API
Additional Information