fix(agw): Creating unique port number for all dedicated bearers

[rsarwad]

fix(agw): Creating unique port number for all dedicated bearers

Summary

On master code base, test case, test test_attach_detach_maxbearers_twopdns.py was failing because, as part of this TC, first PDN is created as part of attach and the dedicated bearer is created with 4 packet filters with port number 5001, 5002, 5003 and 5004.
In next step, secondary PDN is created along with 8 dedicated bearers starting same port numbers.
Since port numbers are same; most of the packet filters have loaded to secondary PDN's default bearer.
Now added logic to assign unique port number for all packet filters of dedicated bearer

Test Plan

Executed test_attach_detach_maxbearers_twopdns.py multiple times

Additional Information

Checking for other test case for which same port numbers are assigned for different dedicated bearer

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

Oops! Looks like you failed the Semantic PR check.

Howto

• Instructions on formatting your PR title
• For PRs with only one commit, the commit message must also be semantic. See Changing a commit message for a howto
• Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the Semantic PR after the last commit.

[github-actions]

Oops! Looks like you failed the Python Format Check.

Howto

• Instructions on running the formatter and linter locally are provided in the format AGW doc
• Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the Python Format Check after the last commit.

[github-actions]

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

• Magma guidelines on signing commits
• About the signoff feature
• Howto: sign-off most-recent commit
• Howto: sign-off multiple past commits
• Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

[github-actions]

feg-workflow

    2 files  202 suites   33s ⏱️
363 tests 363 ✔️ 0 💤 0 ❌
377 runs  377 ✔️ 0 💤 0 ❌

Results for commit 31c250a.

[ssanadhya]

Can we rename loop to a more intuitive variable name, such as num_ims_dedicated_bearers?

[rsarwad]

After this change, flow rules are getting mapped correctly
dedicated, is the file in which flow rules are captured using below command

sudo ovs-ofctl dump-flows gtp_br0 table=0 >dedicated
vagrant@magma-dev-focal:~/2_bearer4/8_ded$ grep -w load:0xb dedicated | grep -c LOCAL
4
vagrant@magma-dev-focal:~/2_bearer4/8_ded$ grep -w load:0xc dedicated | grep -c LOCAL
4
vagrant@magma-dev-focal:~/2_bearer4/8_ded$ grep -w load:0xd dedicated | grep -c LOCAL
4
vagrant@magma-dev-focal:~/2_bearer4/8_ded$ grep -w load:0xe dedicated | grep -c LOCAL
4
vagrant@magma-dev-focal:~/2_bearer4/8_ded$ grep -w load:0xf dedicated | grep -c LOCAL
4
vagrant@magma-dev-focal:~/2_bearer4/8_ded$ grep -w load:0x10 dedicated | grep -c LOCAL
4
vagrant@magma-dev-focal:~/2_bearer4/8_ded$ grep -w load:0x11 dedicated | grep -c LOCAL
4
vagrant@magma-dev-focal:~/2_bearer4/8_ded$ grep -w load:0x12 dedicated | grep -c LOCAL
4

Earlier flow rules were not getting loaded correctly

vagrant@magma-dev-focal:~/2_bearer4$ grep load:0x2 dedicated | grep -c LOCAL
4
vagrant@magma-dev-focal:~/2_bearer4$ grep load:0x3 dedicated | grep -c LOCAL
21
vagrant@magma-dev-focal:~/2_bearer4$ grep load:0x4 dedicated | grep -c LOCAL
3
vagrant@magma-dev-focal:~/2_bearer4$ grep load:0x5 dedicated | grep -c LOCAL
4
vagrant@magma-dev-focal:~/2_bearer4$ grep load:0x6 dedicated | grep -c LOCAL
4
vagrant@magma-dev-focal:~/2_bearer4$ grep load:0x7 dedicated | grep -c LOCAL
25

[github-actions]

agw-workflow

  54 files    84 suites   4m 20s ⏱️
738 tests 729 ✔️ 9 💤 0 ❌
923 runs  914 ✔️ 9 💤 0 ❌

Results for commit 31c250a.

♻️ This comment has been updated with latest results.

[ssanadhya]

Lgtm, verified that make integ_test is passing with this change.

[github-actions]

Unit Test Results

157 files  157 suites   2h 10m 53s ⏱️
307 tests 303 ✔️ 3 💤 1 ❌

For more details on these failures, see this check.

Results for commit c9aafd9.

♻️ This comment has been updated with latest results.