Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dp): Remove grant channel relationship #11971

Merged
merged 1 commit into from Mar 9, 2022

Conversation

jkmar
Copy link
Contributor

@jkmar jkmar commented Mar 4, 2022

Summary

From now grant will store channel data himself,
this is because grant channel does not have to match
any of spectrum inquiry channels.
For example there can be [3550, 3560], [3560, 3570]
spectrum inquiry channels, but grant can be on [3555, 3565].

Signed-off-by: Kuba Marciniszyn kuba@freedomfi.com

@jkmar jkmar requested review from xbend, WojSad and a team March 4, 2022 18:46
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Mar 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

Oops! Looks like you failed the Python Format Check.

Howto

♻️ Updated: ✅ The check is passing the Python Format Check after the last commit.

@jkmar jkmar force-pushed the remove_grant_channel_relation branch from 45e715a to e6b89bb Compare March 4, 2022 19:21
From now grant will store channel data himself,
this is because grant channel does not have to match
any of spectrum inquiry channels.
For example there can be [3550, 3560], [3560, 3570]
spectrum inquiry channels, but grant can be on [3555, 3565].

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
@jkmar jkmar force-pushed the remove_grant_channel_relation branch from e6b89bb to 69048ee Compare March 4, 2022 19:23
@jkmar jkmar requested a review from m-trojanowski March 7, 2022 10:04
@jkmar jkmar merged commit a6d8090 into magma:master Mar 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

Unit Test Results

157 files  157 suites   2h 2m 46s ⏱️
307 tests 303 ✔️ 3 💤 1

For more details on these failures, see this check.

Results for commit a6d8090.

♻️ This comment has been updated with latest results.

@jkmar jkmar deleted the remove_grant_channel_relation branch March 22, 2022 17:35
ardzoht pushed a commit that referenced this pull request Mar 30, 2022
From now grant will store channel data himself,
this is because grant channel does not have to match
any of spectrum inquiry channels.
For example there can be [3550, 3560], [3560, 3570]
spectrum inquiry channels, but grant can be on [3555, 3565].

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
From now grant will store channel data himself,
this is because grant channel does not have to match
any of spectrum inquiry channels.
For example there can be [3550, 3560], [3560, 3570]
spectrum inquiry channels, but grant can be on [3555, 3565].

Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants