New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dp): Remove grant channel relationship #11971
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
Denotes a Pull Request that changes 100-499 lines.
label
Mar 4, 2022
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Python Format Check after the last commit. |
jkmar
force-pushed
the
remove_grant_channel_relation
branch
from
March 4, 2022 19:21
45e715a
to
e6b89bb
Compare
From now grant will store channel data himself, this is because grant channel does not have to match any of spectrum inquiry channels. For example there can be [3550, 3560], [3560, 3570] spectrum inquiry channels, but grant can be on [3555, 3565]. Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
jkmar
force-pushed
the
remove_grant_channel_relation
branch
from
March 4, 2022 19:23
e6b89bb
to
69048ee
Compare
WojSad
approved these changes
Mar 7, 2022
WojSad
approved these changes
Mar 9, 2022
ardzoht
pushed a commit
that referenced
this pull request
Mar 30, 2022
From now grant will store channel data himself, this is because grant channel does not have to match any of spectrum inquiry channels. For example there can be [3550, 3560], [3560, 3570] spectrum inquiry channels, but grant can be on [3555, 3565]. Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
From now grant will store channel data himself, this is because grant channel does not have to match any of spectrum inquiry channels. For example there can be [3550, 3560], [3560, 3570] spectrum inquiry channels, but grant can be on [3555, 3565]. Signed-off-by: Kuba Marciniszyn <kuba@freedomfi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From now grant will store channel data himself,
this is because grant channel does not have to match
any of spectrum inquiry channels.
For example there can be [3550, 3560], [3560, 3570]
spectrum inquiry channels, but grant can be on [3555, 3565].
Signed-off-by: Kuba Marciniszyn kuba@freedomfi.com