Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agw): Enabled flaky retry in CI #12077

Merged
merged 10 commits into from Apr 7, 2022
Merged

fix(agw): Enabled flaky retry in CI #12077

merged 10 commits into from Apr 7, 2022

Conversation

VinashakAnkitAman
Copy link
Member

Title

fix(agw): Enabled flaky retry for failing test cases in CI

Summary

This PR enables flaky test case retry in CI runs

Test plan

Verified with sanity

Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com

@VinashakAnkitAman
fix(agw): Enabled flaky retry in CI
456051e 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@VinashakAnkitAman VinashakAnkitAman requested a review from a team March 10, 2022 22:56
@VinashakAnkitAman VinashakAnkitAman requested a review from a team as a code owner March 10, 2022 22:56
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 10, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Mar 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2022 •
edited

feg-workflow

    2 files  202 suites   34s ⏱️
365 tests 365 ✔️ 0 💤 0 ❌
379 runs  379 ✔️ 0 💤 0 ❌

Results for commit caf9727.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2022 •
edited

agw-workflow

     77 files     122 suites   7m 11s ⏱️
1 134 tests 1 125 ✔️ 9 💤 0 ❌
1 135 runs  1 126 ✔️ 9 💤 0 ❌

Results for commit caf9727.

♻️ This comment has been updated with latest results.

sebathomas
sebathomas approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@sebathomas sebathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good that flaky retries are no longer the default if you run them on your laptop. 👍

ardzoht
ardzoht reviewed Mar 11, 2022
View reviewed changes
Copy link
Contributor

@ardzoht ardzoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update https://github.com/magma/magma/tree/master/lte/gateway/python/integ_tests with two things:

  1. -i flag to enable continuous test runs
  2. enable-flaky-retry flag to perform retries

@VinashakAnkitAman
Addressed Review comments
4030d9a 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@VinashakAnkitAman
Formatted steps
2c11564 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@VinashakAnkitAman VinashakAnkitAman requested review from a team and themarwhal March 16, 2022 14:29
@VinashakAnkitAman
Rebased code and resolved conflicts
2eead2c 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Mar 16, 2022
@github-actions github-actions bot added the component: docs Documentation-related issue label Mar 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2022 •
edited

Oops! Looks like you failed the Markdown lint check.

Howto

♻️ Updated: ✅ The check is passing the Markdown lint check after the last commit.

@VinashakAnkitAman
Converted html tags to markdown style
baea882 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@VinashakAnkitAman
Removed status update in file for now
c20c606 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
ardzoht
ardzoht approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@ardzoht ardzoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VinashakAnkitAman
Rebased code and resolved conflicts
8e21d8f 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
themarwhal
themarwhal approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@themarwhal themarwhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc changes lgtm!

@VinashakAnkitAman
Rebased code and resolved conflicts
37b9c92 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@VinashakAnkitAman
Fixed markdown lint check failure
63fc88d 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@pull-request-size pull-request-size bot added size/XL Denotes a Pull Request that changes 500-999 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Apr 2, 2022
@VinashakAnkitAman
Copy link
Member Author

Hi @themarwhal .. Markdown lint check with insync was always failing on this PR. To fix that I had to commit changes in the file: docs/docusaurus/i18n/en.json. But this file does not include any of my change. Can you please cross-check if I need to commit this file?

@themarwhal
Copy link
Member

Hi @themarwhal .. Markdown lint check with insync was always failing on this PR. To fix that I had to commit changes in the file: docs/docusaurus/i18n/en.json. But this file does not include any of my change. Can you please cross-check if I need to commit this file?

Yes those are good to commit. I will look into why this did not fail on the actual PR that made the change on Monday.

@VinashakAnkitAman
Rebased code and resolved conflicts
caf9727 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@ardzoht ardzoht merged commit 8a2e0ec into magma:master Apr 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022 •
edited

Unit Test Results

157 files  157 suites   2h 3m 56s ⏱️
308 tests 305 ✔️ 3 💤 0 ❌

Results for commit 8a2e0ec.

♻️ This comment has been updated with latest results.

emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@VinashakAnkitAman @emakeev
fix(agw): Enabled flaky retry in CI (magma#12077)
3d9e93d 
* fix(agw): Enabled flaky retry in CI

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>

* Addressed Review comments

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>

* Formatted steps

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>

* Converted html tags to markdown style

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>

* Removed status update in file for now

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>

* Fixed markdown lint check failure

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardzoht ardzoht ardzoht approved these changes

@sebathomas sebathomas sebathomas approved these changes

@themarwhal themarwhal themarwhal approved these changes

@rsarwad rsarwad Awaiting requested review from rsarwad

@koolzz koolzz Awaiting requested review from koolzz koolzz was automatically assigned from magma/approvers-agw

@tmdzk tmdzk Awaiting requested review from tmdzk

Assignees
No one assigned
Labels
component: agw Access gateway-related issue component: docs Documentation-related issue size/XL Denotes a Pull Request that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@VinashakAnkitAman @themarwhal @ardzoht @sebathomas