ci(orc8r): Added Terraform Lint CI Check

[ShubhamTatvamasi]

Signed-off-by: Shubham Tatvamasi shubhamtatvamasi@gmail.com

Summary

Test Plan

Additional Information

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[themarwhal]

lgtm!

[themarwhal]

should we add some concurrency configs? @quentinDERORY

[Neudrino]

concurrency:
  group: ${{ github.workflow }}-${{ github.event.pull_request.number}}
  cancel-in-progress: true

Maybe something like this in alignment with the other linters.

[ShubhamTatvamasi]

For common tasks such as lint check, should we start using actions from marketplace?
https://github.com/marketplace/actions/terraform-lint-action

[ShubhamTatvamasi]

I have updated code, now using action from marketplace.

[Neudrino]

For common tasks such as lint check, should we start using actions from marketplace? https://github.com/marketplace/actions/terraform-lint-action

I agree that using Actions from Marketplace might be a good idea.
However, on top of that we might want to stick to the standard ReviewDog provided linters where possible, as they provide excellent integration with Github out of the box, and avoid custom code here.

In particular for this case this would mean to us tflint.
This would also have the advantage that it could also easily be integrated with our existing set (and setup) of reviewdog.

[github-actions]

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

• Magma guidelines on signing commits
• About the signoff feature
• Howto: sign-off most-recent commit
• Howto: sign-off multiple past commits
• Guide to the different CI checks and resolution guidelines

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

[Neudrino]

More linters are always good and this PR LGTM in general.

We might consider to us tflint and integrate it with our our existing set (and setup) of reviewdog linters to benefit from the excellent Github integration of reviewdog 🐶.