chore(mme): add unit test for fillIpv4

[LKreutzer]

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

• Unit test for SpgwServiceImpl::fillIpv4 is added (see fix(mme): Fix network address in create bearer packet filter #12038)
  • SpgwServiceImpl::fillIpv4 is a private function. The only public function that can lead to calls in fillIpv4 is SpgwServiceImpl::CreateBearer and several conditions need to be fulfilled in order to lead to fillIpv4 calls.
  • It seems that the SpgwServiceImpl::fillIpv4 function is not called in the existing unit tests - all OAI unit tests succeed even if e.g. raise(SIGSEGV); is added to the SpgwServiceImpl::fillIpv4 function. The same if true for the SpgwServiceImpl::CreateBearer function which is the only C/C++ function that can lead to calls of the fillIpv4 function (via fillUpPacketFilterContents).
  • SpgwServiceImpl::fillIpv4 is made public in order to enable direct testing and to limit extensive overhead from indirect testing via SpgwServiceImpl::CreateBearer.

Test Plan

• Run tests make test_oai
• CI

Additional Information

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

feg-workflow

    2 files  202 suites   32s ⏱️
362 tests 362 ✔️ 0 💤 0 ❌
376 runs  376 ✔️ 0 💤 0 ❌

Results for commit d3d2a05.

♻️ This comment has been updated with latest results.

[github-actions]

agw-workflow

  60 files    87 suites   5m 43s ⏱️
970 tests 961 ✔️ 9 💤 0 ❌
971 runs  962 ✔️ 9 💤 0 ❌

Results for commit d3d2a05.

♻️ This comment has been updated with latest results.

[lionelgo]

A public wrapper dedicated to test bool fillIpv4(...) would not change the existing interfaces.
... but would add an interface on the other side.

[themarwhal]

thanks :)