chore: experiment with only applying ASAN and LSAN to Magma C files #12113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
themarwhal
force-pushed
the
omit-asan-instrumentalization
branch
from
d15dd6b
to
07d8f5f
Compare
Signed-off-by: GitHub <noreply@github.com>
themarwhal
force-pushed
the
omit-asan-instrumentalization
branch
from
07d8f5f
to
a174289
Compare
pull-request-size
bot
added
size/XS
LKreutzer
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Tested locally - in pairing with @nstng and @jheidbrink. Python tests still do not work with linkopt. There seems to be no feature to restrict linkopts to certain files.
nstng
approved these changes
Mar 15, 2022
ardzoht
added a commit
to ardzoht/magma
that referenced
this pull request
Mar 16, 2022
* 'master' of github.com:magma/magma: chore: Mark nas_converter_test as manual until flakiness is addressed (magma#12130) chore(mme): address GH11898 (magma#12129) fix(agw): Update DNS resolvers for ec2 instance (magma#12045) feat(feg_relay): move session proxy to NH implementation (magma#11080) chore: Use per_file_copt for MME unit test flag (magma#12112) chore(mme): Remove unused trace defines (magma#12055) chore: experiment with only applying ASAN and LSAN to Magma C files (magma#12113) Revert "test(mme): Add injection of state loaded in S1AP state manager (magma#11456)" (magma#12121) chore: bump ssri (magma#12032) feat(dp): Add grant attempt count (magma#12101) fix(mme): Fix typing_extensions version dependency on magma_test (magma#12110)
ardzoht
pushed a commit
that referenced
this pull request
Mar 30, 2022
…12113) Signed-off-by: GitHub <noreply@github.com>
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
…agma#12113) Signed-off-by: GitHub <noreply@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GitHub noreply@github.com
Summary
Just experimenting to see how the selective ASAN/LSAN enablement affects cache size
Master cache size after running
bazel test //orc8r/gateway/c/... //lte/gateway/c/... --config=asanandbazel test //orc8r/gateway/c/... //lte/gateway/c/... --config=lsan: 13GPR cache size after running
bazel test //orc8r/gateway/c/... //lte/gateway/c/... --config=asanandbazel test //orc8r/gateway/c/... //lte/gateway/c/... --config=lsan: 8.4G@nstng / @LKreutzer I think reducing ASAN/LSAN instrumentalization scope will help the cache size as well. (for CI, at least)
I've also found some repos in sourcegraph use per_file_copt to exclude dependencies from enabling it. https://sourcegraph.com/github.com/google/oss-fuzz/-/blob/projects/envoy/build.sh?L73:10
Test Plan
Additional Information