Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mme): Corrects bazel dependencies for amf_app_test_util #12136

Merged

Conversation

electronjoe
Copy link
Member

@electronjoe electronjoe commented Mar 16, 2022

Per issue detected by @themarwhal at #12124 (comment)

Test Plan

The following is successful:

MAGMA_ROOT=/Users/<username>/Documents/magma/ docker-compose run magma-builder bash
bazel test //lte/gateway/c/core/...

Signed-off-by: Scott Moeller electronjoe@gmail.com

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 16, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2022

feg-workflow

    2 files  202 suites   32s ⏱️
362 tests 362 ✔️ 0 💤 0
376 runs  376 ✔️ 0 💤 0

Results for commit 3fddc56.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2022

agw-workflow

  60 files    87 suites   5m 6s ⏱️
970 tests 961 ✔️ 9 💤 0
971 runs  962 ✔️ 9 💤 0

Results for commit 3fddc56.

♻️ This comment has been updated with latest results.

Per issue detected by @themarwhal at magma#12124 (comment)

Signed-off-by: Scott Moeller <electronjoe@gmail.com>
@electronjoe electronjoe force-pushed the pr-fixup-bazelify-amf-test-util branch from de213fe to 3fddc56 Compare March 16, 2022 12:40
@electronjoe electronjoe marked this pull request as ready for review March 16, 2022 12:42
@electronjoe electronjoe requested review from a team and themarwhal March 16, 2022 12:42
@electronjoe electronjoe enabled auto-merge (squash) March 16, 2022 13:12
@electronjoe electronjoe merged commit a83c8a7 into magma:master Mar 16, 2022
vikramgreddy pushed a commit to vikramgreddy/magma that referenced this pull request Mar 23, 2022
)

Per issue detected by @themarwhal at magma#12124 (comment)

## Test Plan

The following is successful:

```
MAGMA_ROOT=/Users/<username>/Documents/magma/ docker-compose run magma-builder bash
bazel test //lte/gateway/c/core/...
```

Signed-off-by: Scott Moeller <electronjoe@gmail.com>
ardzoht pushed a commit that referenced this pull request Mar 30, 2022
Per issue detected by @themarwhal at #12124 (comment)

## Test Plan

The following is successful:

```
MAGMA_ROOT=/Users/<username>/Documents/magma/ docker-compose run magma-builder bash
bazel test //lte/gateway/c/core/...
```

Signed-off-by: Scott Moeller <electronjoe@gmail.com>
@electronjoe electronjoe deleted the pr-fixup-bazelify-amf-test-util branch April 15, 2022 19:14
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
)

Per issue detected by @themarwhal at magma#12124 (comment)

## Test Plan

The following is successful:

```
MAGMA_ROOT=/Users/<username>/Documents/magma/ docker-compose run magma-builder bash
bazel test //lte/gateway/c/core/...
```

Signed-off-by: Scott Moeller <electronjoe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants