Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mme): Fix flaky unit tests #12141

Merged
merged 2 commits into from Mar 16, 2022

Conversation

pruthvihebbani
Copy link
Contributor

fix(mme): Fix flaky unit tests

Summary

Moved EXPECT_CALL before calling the function triggering the event in the EXPECT_CALL

Test Plan

Ran make_test_oai in a loop for half an hour without any failures.

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
@pruthvihebbani pruthvihebbani requested review from a team and ssanadhya March 16, 2022 12:30
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Mar 16, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Mar 16, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  202 suites   33s ⏱️
362 tests 362 ✔️ 0 💤 0
376 runs  376 ✔️ 0 💤 0

Results for commit 0e59dac.

@github-actions
Copy link
Contributor

agw-workflow

  60 files    87 suites   6m 18s ⏱️
970 tests 961 ✔️ 9 💤 0
971 runs  962 ✔️ 9 💤 0

Results for commit 0e59dac.

Copy link
Collaborator

@ssanadhya ssanadhya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ssanadhya ssanadhya merged commit ae15600 into magma:master Mar 16, 2022
vikramgreddy pushed a commit to vikramgreddy/magma that referenced this pull request Mar 23, 2022
* Moved EXPECT_CALL before sending a message

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
ardzoht pushed a commit that referenced this pull request Mar 30, 2022
* Moved EXPECT_CALL before sending a message

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
* Moved EXPECT_CALL before sending a message

Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore failing //lte/gateway/c/core/oai/test/mme_app_task:mme_procedures_test with --config=asan
2 participants