-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nms): Downgrade dependencies to fix NMS #12149
Conversation
NMS was broken on v1.6 due to a bug in the dependencies. Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
4500a3d
to
9352933
Compare
Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
More details about the error:
This seems to be a problem with the queries introduced in magma/fbc-js-core#108, e.g. return await Organization.findOne({
where: {
name: Sequelize.where(
Sequelize.fn('lower', Sequelize.col('name')),
Sequelize.fn('lower', subdomain),
),
},
}); To me, it looks like there should be only one SQL On the other hand, I don't understand why we don't see these issues on Magma master, where we use the same code. |
Closing and reopening to rerun stuck CI. There were a lot of issues in March 2022. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as I can confirm that the changes resolve the described issue on my machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you get yarn.lock
update as well? Otherwise this looks good to me!
Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
I updated |
@andreilee Some required CircleCI checks are pending. Can you merge this anyway, given that we don't use CircleCI anyore? |
Force merging per @andreilee request |
* fix(nms): Downgrade dependencies to fix NMS NMS was broken on v1.6 due to a bug in the dependencies. Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com> * fix(nms): Also update yarn.lock Signed-off-by: Jan Heidbrink <jan.heidbrink@tngtech.com> Co-authored-by: Jan Heidbrink <jan.heidbrink@tngtech.com>
Summary
Users have reported errors starting NMS in v1.6 and v1.6.1 that seem to be due to getting incompatible versions of the DB migration dependencies.
See:
#11291
#11278
#11325
Pinning the versions of @fbcnms/platform-server and @fbcnms/sequelize-models resulted in a different error with an organizations query introduced in:
magma/fbc-js-core#108
By downgrading @fbcnms/platform-server and @fbcnms/express-middleware to a version before that change, I am able to start NMS. This will have the unfortunate side effect that organization queries are no longer case-insensitive.
Test Plan
Check out v1.6 or v1.6.1, build NMS according to the Quick Start Guide and try to log in using admin@magma.test.
Additional Information