Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor bazel binaries to only include main.py #12154

Merged
merged 4 commits into from Mar 17, 2022
Merged

refactor: Refactor bazel binaries to only include main.py #12154

merged 4 commits into from Mar 17, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Mar 16, 2022 •
edited

Summary

  • The py_binarys of eventd, redirectd, policydb and mobilityd are refactored to only include the main.py.
  • Other source files are moved to separate py_librarys.
  • See Bazel technical debt #11743
  • Note: Review on commit by commit basis

Test Plan

  • Run tests with bazel in dev-container and in bazel-base:
    bazel test //orc8r/gateway/python/... //lte/gateway/python/...

  • Run services with bazel in dev-container and in bazel-base:

bazel run //lte/gateway/python/magma/redirectd:redirectd
bazel run //lte/gateway/python/magma/policydb:policydb
bazel run //lte/gateway/python/magma/mobilityd:mobilityd
bazel run //orc8r/gateway/python/magma/eventd:eventd

Additional Information

  • This change is backwards-breaking

@LKreutzer
refactor(redirectd): split bazel python binary
f472c4b 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer
refactor(policydb): split bazel python binary
7aef426 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer
refactor(eventd): split bazel python binary
5b4ccb2 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer
refactor(mobilityd): split bazel python binary
6ac063b 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer added the bazel changes for the Bazelification effort label Mar 16, 2022
@LKreutzer LKreutzer requested a review from nstng March 16, 2022 16:31
@LKreutzer LKreutzer self-assigned this Mar 16, 2022
@LKreutzer LKreutzer requested a review from a team March 16, 2022 16:31
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Mar 16, 2022
@electronjoe
Copy link
Member

Nice cleanup!

nstng
nstng approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the cleanup!

@LKreutzer LKreutzer changed the title Refactor bazel binaries to only include main.py refactor: Refactor bazel binaries to only include main.py Mar 17, 2022
@LKreutzer LKreutzer added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Mar 17, 2022
@LKreutzer LKreutzer mentioned this pull request Mar 17, 2022
Closed
@themarwhal themarwhal merged commit 0ff5b34 into magma:master Mar 17, 2022
@nstng nstng linked an issue Mar 18, 2022 that may be closed by this pull request
Bazel technical debt #11743
Closed
vikramgreddy pushed a commit to vikramgreddy/magma that referenced this pull request Mar 23, 2022
@LKreutzer @vikramgreddy
refactor: Refactor bazel binaries to only include main.py (magma#12154)
4bd7881 
* refactor(redirectd): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

* refactor(policydb): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

* refactor(eventd): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

* refactor(mobilityd): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
ardzoht pushed a commit that referenced this pull request Mar 30, 2022
@LKreutzer @ardzoht
refactor: Refactor bazel binaries to only include main.py (#12154)
e848d82 
* refactor(redirectd): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

* refactor(policydb): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

* refactor(eventd): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

* refactor(mobilityd): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@LKreutzer @emakeev
refactor: Refactor bazel binaries to only include main.py (magma#12154)
9f90849 
* refactor(redirectd): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

* refactor(policydb): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

* refactor(eventd): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

* refactor(mobilityd): split bazel python binary

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electronjoe electronjoe electronjoe approved these changes

@themarwhal themarwhal themarwhal approved these changes

@nstng nstng nstng approved these changes

Assignees

@LKreutzer LKreutzer

Labels
bazel changes for the Bazelification effort ready2merge This PR is ready to be merged (is approved and passes all required checks) size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bazel technical debt
4 participants
@LKreutzer @electronjoe @themarwhal @nstng