fix(orc8r): Fix missing cloud health servicer init #12160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunter Gatewood <hgatewood@gmail.com>
uri200
approved these changes
Mar 17, 2022
vikramgreddy
pushed a commit
to vikramgreddy/magma
that referenced
this pull request
Mar 23, 2022
ardzoht
pushed a commit
that referenced
this pull request
Mar 30, 2022
1 task
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of separating out the health servicer into its internal and southbound components, the internal component was not initialized in the main.go. Fix: initialize it in the main.go.
Side note: this is an unfortunate side effect of our current pattern of using non-trivial + un-tested main.go files
Test Plan
test_in_staging.gif
Additional Information