Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(session_proxy): Add Rentransmits field to diam client #12194

Merged
merged 1 commit into from Mar 21, 2022
Merged

fix(session_proxy): Add Rentransmits field to diam client #12194

merged 1 commit into from Mar 21, 2022

Conversation

uri200
Copy link
Contributor

@uri200 uri200 commented Mar 17, 2022 •
edited

Signed-off-by: Oriol Batalla obatalla@fb.com

Summary

Reatempts field was on configuration file but it was never parsed and configured into diameter client

This PR fixes that and adds some logs to provide visibility into the config

This PR is related to #12192

Test Plan

session_proxy    | I0317 23:18:56.756850       1 main.go:168] Gy client: &{Host:string Realm:string ProductName:string AppID:4 AuthAppID:0 Retransmits:3 WatchdogInterval:3 RetryCount:5 SupportedVendorIDs: ServiceContextId:}, Gy server: &{DiameterServerConnConfig:{Addr:172
.16.1.14:3868 Protocol:sctp LocalAddr:172.16.1.13:3906} DestHost:magma-fedgw.magma.com DestRealm:magma.com DisableDestHost:false OverwriteDestHost:false}

Additional Information

  • This change is backwards-breaking

@uri200 uri200 requested review from a team and themarwhal March 17, 2022 23:42
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Mar 17, 2022
@uri200 uri200 requested a review from emakeev March 17, 2022 23:43
@uri200 uri200 force-pushed the session_proxy_fix_missing_reattempts_field branch from fe81930 to 99aec0b Compare March 17, 2022 23:45
@uri200 uri200 force-pushed the session_proxy_fix_missing_reattempts_field branch from 99aec0b to ad0433a Compare March 21, 2022 19:19
@uri200
fix(session_proxy): Add Rentransmits field to diam client
53252d1 
Signed-off-by: Oriol Batalla <obatalla@fb.com>
@uri200 uri200 force-pushed the session_proxy_fix_missing_reattempts_field branch from ad0433a to 53252d1 Compare March 21, 2022 20:09
@uri200 uri200 changed the title feg(session_proxy): Add Rentransmits field to diam client fix(session_proxy): Add Rentransmits field to diam client Mar 21, 2022
@uri200 uri200 merged commit 1683ca9 into magma:master Mar 21, 2022
@uri200 uri200 deleted the session_proxy_fix_missing_reattempts_field branch March 21, 2022 22:56
tmdzk pushed a commit that referenced this pull request Mar 23, 2022
@uri200
fix(session_proxy): Add Rentransmits field to diam client (#12194)
f7db750
ardzoht pushed a commit that referenced this pull request Mar 30, 2022
@uri200 @ardzoht
fix(session_proxy): Add Rentransmits field to diam client (#12194)
f42de69
@uri200 uri200 mentioned this pull request Jun 9, 2022
Closed
mattymo pushed a commit that referenced this pull request Jul 6, 2022
@uri200 @119Vik
fix(session_proxy): Add Rentransmits field to diam client (#12194)
82a6ece
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@uri200 @emakeev
fix(session_proxy): Add Rentransmits field to diam client (magma#12194)
b104496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emakeev emakeev emakeev approved these changes

@themarwhal themarwhal Awaiting requested review from themarwhal

Assignees
No one assigned
Labels
apply-v1.7 size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uri200 @emakeev