Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable //lte/gateway/c/core/oai/test/spgw_task:spgw_procedures… #12246

Merged
merged 1 commit into from Mar 23, 2022

Conversation

themarwhal
Copy link
Member

@themarwhal themarwhal commented Mar 22, 2022

…_test for CI runs

Signed-off-by: GitHub noreply@github.com

Summary

This test no longer has issues with ASAN or plain mode. Removing the manual tag will add the test to the suite of tests that gets run in CI.

This fully closes out #11984

Test Plan

Ran the following commands to make sure the test is not flaky

bazel test //lte/gateway/c/core/oai/test/spgw_task:spgw_procedures_test --runs_per_test=100
bazel test //lte/gateway/c/core/oai/test/spgw_task:spgw_procedures_test --runs_per_test=100 --config=asan
bazel test //lte/gateway/c/core/oai/test/spgw_task:spgw_procedures_test --config=lsan --runs_per_test=100

Additional Information

  • This change is backwards-breaking

…_test for CI runs

Signed-off-by: GitHub <noreply@github.com>
@themarwhal themarwhal requested review from a team and nstng March 22, 2022 20:46
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 22, 2022
@themarwhal themarwhal enabled auto-merge (squash) March 22, 2022 20:46
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Mar 22, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  202 suites   32s ⏱️
362 tests 362 ✔️ 0 💤 0
376 runs  376 ✔️ 0 💤 0

Results for commit aff3026.

@github-actions
Copy link
Contributor

agw-workflow

     71 files     101 suites   6m 52s ⏱️
1 015 tests 1 006 ✔️ 9 💤 0
1 016 runs  1 007 ✔️ 9 💤 0

Results for commit aff3026.

@electronjoe
Copy link
Member

What is the status of GH11984 after this PR? And what about lsan?

Copy link
Member

@electronjoe electronjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% questions I posed in GH PR

@themarwhal themarwhal merged commit dde5298 into magma:master Mar 23, 2022
@themarwhal themarwhal deleted the enable-spgw-procedures branch March 23, 2022 13:33
@themarwhal
Copy link
Member Author

What is the status of GH11984 after this PR? And what about lsan?

I've updated the PR description to include status of #11984 and that bazel test //lte/gateway/c/core/oai/test/spgw_task:spgw_procedures_test --config=lsan --runs_per_test=100 successfully runs

@Neudrino Neudrino mentioned this pull request Mar 24, 2022
1 task
ardzoht pushed a commit that referenced this pull request Mar 30, 2022
…_test for CI runs (#12246)

Signed-off-by: GitHub <noreply@github.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…_test for CI runs (magma#12246)

Signed-off-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants