Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cut 1.7.0 new documentation #12276

Merged
merged 1 commit into from Mar 29, 2022
Merged

docs: cut 1.7.0 new documentation #12276

merged 1 commit into from Mar 29, 2022

Conversation

uri200
Copy link
Contributor

@uri200 uri200 commented Mar 24, 2022

Signed-off-by: Oriol Batalla obatalla@fb.com

Summary

Update Magma doc site to include 1.7.0,

Will be merged once 1.7 is official

Test Plan

image

Additional Information

  • This change is backwards-breaking

@uri200 uri200 requested review from a team and electronjoe March 24, 2022 18:59
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Mar 24, 2022
@uri200 uri200 requested a review from themarwhal March 24, 2022 18:59
@github-actions github-actions bot added the component: docs Documentation-related issue label Mar 24, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2022

Oops! Looks like you failed the Markdown lint check.

Howto

♻️ Updated: ❌ The check is still failing the Markdown lint check after the last commit.

@pull-request-size pull-request-size bot added size/XXL Denotes a Pull Request that changes 1000+ lines. and removed size/L Denotes a Pull Request that changes 100-499 lines. labels Mar 24, 2022

## Introduction

Currently, mobility in Magma is limited to RAN a single AGW where RAN elements support the X2 interface. This isn't always feasible; S1 mobility is the "fallback" method for mobility in LTE networks when X2 isn't avaialble. The scope of this proposal is enhancing intra-AGW mobility (that is, mobility that does not cross an AGW boundary) using S1 handover. Although *inter-AGW* mobility is not within scope of this proposal, the signalling mechanisms necessary for S1 handover will be useful for future mobility proposals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"avaialble" is a misspelling of "available"


## Introduction

Currently, mobility in Magma is limited to RAN a single AGW where RAN elements support the X2 interface. This isn't always feasible; S1 mobility is the "fallback" method for mobility in LTE networks when X2 isn't avaialble. The scope of this proposal is enhancing intra-AGW mobility (that is, mobility that does not cross an AGW boundary) using S1 handover. Although *inter-AGW* mobility is not within scope of this proposal, the signalling mechanisms necessary for S1 handover will be useful for future mobility proposals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"signalling" is a misspelling of "signaling"


The traditional S1 mobility call flow is our guide. A good overview of this particular flow is available [here](https://www.eventhelix.com/lte/handover/s1/).

### S1AP Signalling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"Signalling" is a misspelling of "Signaling"


- Ensure that for each commit of each PR all unit test jobs are executed by CircleCI
- Ensure that each PR was reviewed and accepted by component maintainer
- Ensure that each PR which succesfully passed unit testing and maintainer review gets "ready-to-merge" label assigned.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"succesfully" is a misspelling of "successfully"


### Existing test env is a VirtualBox VMs managed by Vagrant on top of KVM VMs which are running on baremetall node is very slow

As we found as a result of performance tests current setup gives us low performace because of Virtualbox running in KVM. Best option we can suggest so far is start using libvirt based vagrant boxes which 2-3 times faster then Virtualbox.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"performace" is a misspelling of "performance"

┏Access Control & ┓ ┏━━━━Session━━━━┓ │ ┏━━━━Device━━━━━┓ │┏━━━Optional━━━━┓
┃ Management ┃ ┃ & Policy ┃ │ ┃ Management ┃ │┃ Services ┃
┃ ┌───────────┐ ┃ ┃ Management ┃ │ ┃ ┌───────────┐ ┃ │┃ ┌────────────┐┃
┃ │ MME │ ┃ ┃ ┌───────────┐ ┃ └──╋─│ magmad │ ┃ │┃ │ monitord │┃
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"monitord" is a misspelling of "monitored"


Dynamic services are optional AGW services that must be enabled by updating the AGW's *magmad* configuration.

### Monitord
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"Monitord" is a misspelling of "Monitored"


### Monitord

*monitord* service. Monitors the CPEs connected to the AGW. Sends ICMP pings to the CPEs connected to the gateway and reports liveness metrics.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"monitord" is a misspelling of "monitored"

already do this for the check quota service in CWF we take a lock when assigning
an internal IP to prevent collisions. By assigning an internal IP in the same
subnet as the Redirection server(which listens on OVS internal port) we get to
use the deafult ip route that will send the redirect server responses back to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"deafult" is a misspelling of "default"

First, on the gateway, events are aggregated by the `eventd` service.
To fire events, the gRPC interface on `eventd` must be called.
The `eventd` service is responsible for sending these events to Fluent Bit,
labelled as `td-agent-bit` on the diagram above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"labelled" is a misspelling of "labeled"

Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I did not review every single file, as this is a migration (or version release).

  • We should probably make sure it was rebased with newest changes added between creation an merging the PR. 😉

Copy link
Member

@electronjoe electronjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% @Neudrino good advice

@uri200
Copy link
Contributor Author

uri200 commented Mar 28, 2022

Hey @Neudrino rebase will be done right before we release to make sure we collect everything

Signed-off-by: Oriol Batalla <obatalla@fb.com>
@uri200 uri200 merged commit 85d52a6 into magma:master Mar 29, 2022
@uri200 uri200 deleted the docs_v1.7 branch March 29, 2022 22:05
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: docs Documentation-related issue size/XXL Denotes a Pull Request that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants