New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: cut 1.7.0 new documentation #12276
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Oops! Looks like you failed the Howto
♻️ Updated: ❌ The check is still failing the Markdown lint check after the last commit. |
|
||
## Introduction | ||
|
||
Currently, mobility in Magma is limited to RAN a single AGW where RAN elements support the X2 interface. This isn't always feasible; S1 mobility is the "fallback" method for mobility in LTE networks when X2 isn't avaialble. The scope of this proposal is enhancing intra-AGW mobility (that is, mobility that does not cross an AGW boundary) using S1 handover. Although *inter-AGW* mobility is not within scope of this proposal, the signalling mechanisms necessary for S1 handover will be useful for future mobility proposals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[misspell] reported by reviewdog 🐶
"avaialble" is a misspelling of "available"
|
||
## Introduction | ||
|
||
Currently, mobility in Magma is limited to RAN a single AGW where RAN elements support the X2 interface. This isn't always feasible; S1 mobility is the "fallback" method for mobility in LTE networks when X2 isn't avaialble. The scope of this proposal is enhancing intra-AGW mobility (that is, mobility that does not cross an AGW boundary) using S1 handover. Although *inter-AGW* mobility is not within scope of this proposal, the signalling mechanisms necessary for S1 handover will be useful for future mobility proposals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[misspell] reported by reviewdog 🐶
"signalling" is a misspelling of "signaling"
|
||
The traditional S1 mobility call flow is our guide. A good overview of this particular flow is available [here](https://www.eventhelix.com/lte/handover/s1/). | ||
|
||
### S1AP Signalling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[misspell] reported by reviewdog 🐶
"Signalling" is a misspelling of "Signaling"
|
||
- Ensure that for each commit of each PR all unit test jobs are executed by CircleCI | ||
- Ensure that each PR was reviewed and accepted by component maintainer | ||
- Ensure that each PR which succesfully passed unit testing and maintainer review gets "ready-to-merge" label assigned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[misspell] reported by reviewdog 🐶
"succesfully" is a misspelling of "successfully"
|
||
### Existing test env is a VirtualBox VMs managed by Vagrant on top of KVM VMs which are running on baremetall node is very slow | ||
|
||
As we found as a result of performance tests current setup gives us low performace because of Virtualbox running in KVM. Best option we can suggest so far is start using libvirt based vagrant boxes which 2-3 times faster then Virtualbox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[misspell] reported by reviewdog 🐶
"performace" is a misspelling of "performance"
┏Access Control & ┓ ┏━━━━Session━━━━┓ │ ┏━━━━Device━━━━━┓ │┏━━━Optional━━━━┓ | ||
┃ Management ┃ ┃ & Policy ┃ │ ┃ Management ┃ │┃ Services ┃ | ||
┃ ┌───────────┐ ┃ ┃ Management ┃ │ ┃ ┌───────────┐ ┃ │┃ ┌────────────┐┃ | ||
┃ │ MME │ ┃ ┃ ┌───────────┐ ┃ └──╋─│ magmad │ ┃ │┃ │ monitord │┃ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[misspell] reported by reviewdog 🐶
"monitord" is a misspelling of "monitored"
|
||
Dynamic services are optional AGW services that must be enabled by updating the AGW's *magmad* configuration. | ||
|
||
### Monitord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[misspell] reported by reviewdog 🐶
"Monitord" is a misspelling of "Monitored"
|
||
### Monitord | ||
|
||
*monitord* service. Monitors the CPEs connected to the AGW. Sends ICMP pings to the CPEs connected to the gateway and reports liveness metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[misspell] reported by reviewdog 🐶
"monitord" is a misspelling of "monitored"
already do this for the check quota service in CWF we take a lock when assigning | ||
an internal IP to prevent collisions. By assigning an internal IP in the same | ||
subnet as the Redirection server(which listens on OVS internal port) we get to | ||
use the deafult ip route that will send the redirect server responses back to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[misspell] reported by reviewdog 🐶
"deafult" is a misspelling of "default"
First, on the gateway, events are aggregated by the `eventd` service. | ||
To fire events, the gRPC interface on `eventd` must be called. | ||
The `eventd` service is responsible for sending these events to Fluent Bit, | ||
labelled as `td-agent-bit` on the diagram above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[misspell] reported by reviewdog 🐶
"labelled" is a misspelling of "labeled"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, I did not review every single file, as this is a migration (or version release).
- We should probably make sure it was rebased with newest changes added between creation an merging the PR. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
% @Neudrino good advice
Hey @Neudrino rebase will be done right before we release to make sure we collect everything |
Signed-off-by: Oriol Batalla <obatalla@fb.com>
Signed-off-by: Oriol Batalla obatalla@fb.com
Summary
Update Magma doc site to include 1.7.0,
Will be merged once 1.7 is official
Test Plan
Additional Information