New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pipelined): devcontainer and bazel-base use needed depencies #12285
chore(pipelined): devcontainer and bazel-base use needed depencies #12285
Conversation
Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the Hadolint findings in the PR useful?
They make sense, but we never used version pinning in these Dockerfile-s. If we want to use this, then we should do it in a separated technical debt task. The other issues were not introduced here, but are related to the changed lines (of course this is not an argument to not fix it, but this should again be done in a separate task for all occurences). Is this ok for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in pairing
…12285) Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
…agma#12285) Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
Signed-off-by: Krisztián Varga krisztian.varga@tngtech.com
Summary
Add needed dependencies for devcontainer and bazel-base which are required by #12271
Test Plan
No docker build failures in CI. Tested locally with #12271.
Additional Information