Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pipelined): devcontainer and bazel-base use needed depencies #12285

Merged

Conversation

vktng
Copy link
Contributor

@vktng vktng commented Mar 25, 2022

Signed-off-by: Krisztián Varga krisztian.varga@tngtech.com

Summary

Add needed dependencies for devcontainer and bazel-base which are required by #12271

Test Plan

No docker build failures in CI. Tested locally with #12271.

Additional Information

  • This change is backwards-breaking

Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
@vktng vktng added the bazel changes for the Bazelification effort label Mar 25, 2022
@vktng vktng requested review from a team and electronjoe March 25, 2022 10:33
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Mar 25, 2022
@vktng vktng requested a review from nstng March 25, 2022 10:33
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

Copy link
Member

@electronjoe electronjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the Hadolint findings in the PR useful?

@vktng
Copy link
Contributor Author

vktng commented Mar 25, 2022

Are the Hadolint findings in the PR useful?

They make sense, but we never used version pinning in these Dockerfile-s. If we want to use this, then we should do it in a separated technical debt task. The other issues were not introduced here, but are related to the changed lines (of course this is not an argument to not fix it, but this should again be done in a separate task for all occurences). Is this ok for you?

Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in pairing

@nstng nstng merged commit 53c4848 into magma:master Mar 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022

Unit Test Results

157 files  157 suites   2h 4m 59s ⏱️
307 tests 304 ✔️ 3 💤 0

Results for commit 53c4848.

♻️ This comment has been updated with latest results.

ardzoht pushed a commit that referenced this pull request Mar 30, 2022
…12285)

Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…agma#12285)

Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants