Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix codecov_src_go by specifying go version #12305

Merged
merged 1 commit into from Apr 12, 2022

Conversation

voisey
Copy link
Contributor

@voisey voisey commented Mar 28, 2022

Prerequisite for #12151.

Summary

codecov_src_go is failing here, for example, because os.ReadFile and os.WriteFile are undefined. I believe this is because an inconsistent version of Go is being used for the test (1.15.15), since a version >= 1.16 is required to use these functions. Before 1.16, these functions were instead defined by the io/ioutil package (see e.g. here). Here, I specify version 1.18, which is the latest available release, which requires updating actions/setup-go from v2 to v3.

Test Plan

Checked that codecov_src_go downloads Go 1.18 as desired and passes: https://github.com/magma/magma/runs/5717337059?check_suite_focus=true.

Additional Information

  • This change is backwards-breaking

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 28, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Mar 28, 2022
@voisey voisey marked this pull request as ready for review March 28, 2022 09:56
@voisey voisey requested a review from a team as a code owner March 28, 2022 09:56
@voisey voisey requested a review from 119Vik March 28, 2022 09:56
@uri200
Copy link
Contributor

uri200 commented Apr 11, 2022

will codecov still work with current go version without this #12151?

@tmdzk tmdzk merged commit 71cccd2 into magma:master Apr 12, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants