New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(mme): Remove manual tag from mme_procedures_test #12317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Signed-off-by: GitHub <noreply@github.com>
themarwhal
force-pushed
the
remove-last-manual
branch
from
March 28, 2022 17:45
b4f360a
to
37fd3df
Compare
This is a followup to @ssanadhya 's PR: #12297 |
ssanadhya
approved these changes
Mar 28, 2022
nstng
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only did --runs_per_test=20
but they were all green - lgtm
ardzoht
pushed a commit
that referenced
this pull request
Mar 30, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marie Bremner marwhal@fb.com
Summary
Remove the last "manual" tag from MME unit tests. The flakiness was addressed in #12297
I'll keep the flaky tag as we still seem to see failures occasionally but at a MUCH lower frequency. (see test plan)
Test Plan
Run
bazel test //lte/gateway/c/core/oai/test/mme_app_task:mme_procedures_test --runs_per_test=1000
and got failure only 1/1000 timesAdditional Information