Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mme): Remove manual tag from mme_procedures_test #12317

Merged
merged 1 commit into from Mar 28, 2022

Conversation

themarwhal
Copy link
Member

@themarwhal themarwhal commented Mar 28, 2022

Signed-off-by: Marie Bremner marwhal@fb.com

Summary

Remove the last "manual" tag from MME unit tests. The flakiness was addressed in #12297

I'll keep the flaky tag as we still seem to see failures occasionally but at a MUCH lower frequency. (see test plan)

Test Plan

Run bazel test //lte/gateway/c/core/oai/test/mme_app_task:mme_procedures_test --runs_per_test=1000 and got failure only 1/1000 times
Screen Shot 2022-03-28 at 1 49 59 PM

Additional Information

  • This change is backwards-breaking

@themarwhal themarwhal requested review from a team and nstng March 28, 2022 17:19
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 28, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Mar 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2022

feg-workflow

    2 files  202 suites   32s ⏱️
362 tests 362 ✔️ 0 💤 0
376 runs  376 ✔️ 0 💤 0

Results for commit 37fd3df.

♻️ This comment has been updated with latest results.

Signed-off-by: GitHub <noreply@github.com>
@themarwhal
Copy link
Member Author

This is a followup to @ssanadhya 's PR: #12297

@github-actions
Copy link
Contributor

agw-workflow

     77 files     122 suites   6m 35s ⏱️
1 133 tests 1 124 ✔️ 9 💤 0
1 134 runs  1 125 ✔️ 9 💤 0

Results for commit 37fd3df.

Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only did --runs_per_test=20 but they were all green - lgtm

@themarwhal themarwhal merged commit 86e5da4 into magma:master Mar 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2022

Unit Test Results

157 files  157 suites   2h 3m 40s ⏱️
307 tests 304 ✔️ 3 💤 0

Results for commit 86e5da4.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants