Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): postpone lldb install until after unattended-upgrades #12329

Merged
merged 1 commit into from Mar 29, 2022
Merged

fix(ci): postpone lldb install until after unattended-upgrades #12329

merged 1 commit into from Mar 29, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Mar 29, 2022 •
edited

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

Test Plan

  • Run LTE integ test workflow via GH actions (on fork)

Additional Information

  • This change is backwards-breaking

@LKreutzer LKreutzer requested a review from a team as a code owner March 29, 2022 10:00
@LKreutzer LKreutzer self-assigned this Mar 29, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Mar 29, 2022
@LKreutzer LKreutzer requested a review from uri200 March 29, 2022 10:00
@LKreutzer LKreutzer linked an issue Mar 29, 2022 that may be closed by this pull request
vagrant up magma fails in CI due to unattended upgrade #12326
Closed
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Mar 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2022 •
edited

feg-workflow

    2 files  202 suites   32s ⏱️
362 tests 362 ✔️ 0 💤 0 ❌
376 runs  376 ✔️ 0 💤 0 ❌

Results for commit f5ba5c6.

♻️ This comment has been updated with latest results.

@LKreutzer
fix(ci): postpone lldb install until after unattended-upgrades
f5ba5c6 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
jheidbrink
jheidbrink reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@jheidbrink jheidbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in pairing

@github-actions
Copy link
Contributor

agw-workflow

     77 files     122 suites   7m 48s ⏱️
1 132 tests 1 123 ✔️ 9 💤 0 ❌
1 133 runs  1 124 ✔️ 9 💤 0 ❌

Results for commit f5ba5c6.

@LKreutzer LKreutzer added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Mar 29, 2022
@themarwhal themarwhal merged commit 236d88a into magma:master Mar 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2022 •
edited

Unit Test Results

154 files  154 suites   2h 8m 54s ⏱️
304 tests 300 ✔️ 3 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit 236d88a.

♻️ This comment has been updated with latest results.

ardzoht pushed a commit that referenced this pull request Mar 30, 2022
@LKreutzer @ardzoht
fix(ci): postpone lldb install until after unattended-upgrades (#12329)
007efa6 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@jheidbrink jheidbrink mentioned this pull request Jun 17, 2022
Merged
1 task
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@LKreutzer @emakeev
fix(ci): postpone lldb install until after unattended-upgrades (magma…
687545a 
…#12329)

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jheidbrink jheidbrink jheidbrink approved these changes

@themarwhal themarwhal themarwhal approved these changes

@uri200 uri200 Awaiting requested review from uri200 uri200 was automatically assigned from magma/approvers-agw

Assignees

@jheidbrink jheidbrink

@LKreutzer LKreutzer

Labels
component: agw Access gateway-related issue ready2merge This PR is ready to be merged (is approved and passes all required checks) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vagrant up magma fails in CI due to unattended upgrade
3 participants
@LKreutzer @jheidbrink @themarwhal