Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): push domain-proxy docker images to remote repository. #12331

Merged

Conversation

m-trojanowski
Copy link
Contributor

Summary

This PR adds domain proxy docker images push to remote magma repository.

Test Plan

All tests should pass

@m-trojanowski m-trojanowski requested a review from a team March 29, 2022 13:43
@m-trojanowski m-trojanowski requested a review from a team as a code owner March 29, 2022 13:43
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Mar 29, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Mar 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2022

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

@m-trojanowski m-trojanowski force-pushed the push-dp-docker-images-do-magma-repo branch from 268854e to 38b2462 Compare March 29, 2022 14:55
Copy link
Collaborator

@tmdzk tmdzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

dp/skaffold.yaml Outdated Show resolved Hide resolved
@m-trojanowski m-trojanowski force-pushed the push-dp-docker-images-do-magma-repo branch from 38b2462 to 3fa5294 Compare March 31, 2022 09:17
Signed-off-by: Marcin Trojanowski <marcin.trojanowski@freedomfi.com>
@m-trojanowski m-trojanowski force-pushed the push-dp-docker-images-do-magma-repo branch from 3fa5294 to d3cab18 Compare March 31, 2022 09:19
@m-trojanowski m-trojanowski enabled auto-merge (squash) March 31, 2022 10:19
@m-trojanowski m-trojanowski merged commit 4d7fae0 into magma:master Mar 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2022

Unit Test Results

157 files  157 suites   2h 14m 4s ⏱️
307 tests 304 ✔️ 3 💤 0

Results for commit 4d7fae0.

♻️ This comment has been updated with latest results.

@nstng
Copy link
Contributor

nstng commented Apr 5, 2022

@m-trojanowski

@xbend xbend deleted the push-dp-docker-images-do-magma-repo branch May 19, 2022 12:10
tmdzk pushed a commit that referenced this pull request Jul 22, 2022
Signed-off-by: Marcin Trojanowski <marcin.trojanowski@freedomfi.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
…a#12331)

Signed-off-by: Marcin Trojanowski <marcin.trojanowski@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants