chore(pipelined): blocking of local ipv6 addresses is supported #12339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XL
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Python Format Check after the last commit. |
pshelar
reviewed
Mar 31, 2022
...ots/test_access_control.AccessControlTestLocalIpBlockLTEIpV6.test_blocking_ip_match.snapshot
Show resolved
Hide resolved
nstng
force-pushed
the
pipelined_block_local_ipv6
branch
2 times, most recently
from
f7a8b7e
to
b9ccd38
Compare
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the DCO check after the last commit. |
nstng
force-pushed
the
pipelined_block_local_ipv6
branch
from
a354e3e
to
151cccc
Compare
pshelar
approved these changes
Apr 4, 2022
| ), | ||
| ip_proto=IPPROTO_ICMP, | ||
| ) | ||
| return MagmaMatch( |
There was a problem hiding this comment.
better readability you could add 'else' here.
sebathomas
reviewed
Apr 5, 2022
lte/gateway/python/magma/pipelined/tests/test_access_control.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
nstng
force-pushed
the
pipelined_block_local_ipv6
branch
from
151cccc
to
85f4a50
Compare
sebathomas
approved these changes
Apr 5, 2022
nstng
added
ready2merge
|
running integ tests on fork: https://github.com/nstng/magma/actions/runs/2096312195 (/) |
nstng
added
the
ready2merge
sreedharkumartn
added a commit
to sreedharkumartn/magma
that referenced
this pull request
Apr 12, 2022
…a#12339) Signed-off-by: sreedharkumartn <sreedhar.kumar@wavelabs.ai>
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
…a#12339) * chore(pipelined): access control test is refactored Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * chore(pipelined): blocking of local ipv6 addresses is supported Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> * chore(pipelined): blocking of local ipv6 addresses is tested Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #12074.
Couple of notes and questions @pshelar and @koolzz:
access_control.pyusesnetifaceswhich is outdatedfe80::addresses as these are not static in the vm setup - and it is disproportionate to make them static. Is there a test mechanic we did not see that achieves the same?127.*addresses are blocked - from our research we found that there is not really a fixed ipv6 block for loopback addresses. For now we only blocked in this case::1. What is your expectation here?Test Plan
Mainly
test_access_control.py.Additional Information