ci: always pull docker image from remote to prevent out of sync tags #12351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to prevent out of sync tags Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
pull-request-size
bot
added
size/S
|
Looks like the OWNERS masks are confusing this GitHub workflow for a bazel BUILD file? Hence the review is only |
1 task
…ulling Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Neudrino
force-pushed
the
ci/always-pull-docker-image-on-run
branch
from
5eb376d
to
c99eb89
Compare
nstng
requested changes
Mar 30, 2022
|
Tested extensively on #12271. Image was updated correctly 👍 . We should track somewhere that this should be changed for all workflows that use the latest devcontainer image. |
This file was added on purpose to |
nstng
approved these changes
Mar 30, 2022
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
…agma#12351) * ci: always pull docker image from remote ... to prevent out of sync tags Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> * ci: update docker action to v3 Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> * ci: ensure the devcontainer latest tag is up to date locally before pulling Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Github action runners are not managed by Magma and might be reused several times. The docker documentation seems to suggest, that if a image is already present in the local docker registry, it will not be re-fetched from the remote unless explicitly told so. See the option
--pullwith defaultmissingin the docker documentation. This can lead to stale images being used.To mitigate the issue we need to force pull the first time we use an image within the workflow.
Keep in mind that we do not want to force pull in every following action as this would bring the risk to use different images in one workflow run, when a image tag is updated during that workflow run.
The
addnab/docker-run-actionrequired an update to versionv3for this to work.Test Plan
Additional Information