Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dp): Unregister CBSD on SAS response 105 #12360

Merged
merged 1 commit into from Mar 31, 2022

Conversation

xbend
Copy link
Contributor

@xbend xbend commented Mar 31, 2022

Fixed an issue where a CBSD state remained "registered" when SAS
returned a response with reponseCode 105.
Response code 105 means the CBSD got unregistered in SAS and should
consider itself "Unregistered".
This PR changes the CBSD state to "unregistered" when any SAS response
is a 105 code.

Signed-off-by: Artur Dębski artur.debski@freedomfi.com

Summary

  • Set CBSD state to "Unregistered" on each SAS response that has the responseCode 105.

Additional Information

  • This change is backwards-breaking

Fixed an issue where a CBSD state remained "registered" when SAS
returned a response with reponseCode 105.
Response code 105 means the CBSD got unregistered in SAS and should
consider itself "Unregistered".
This PR changes the CBSD state to "unregistered" when any SAS response
is a 105 code.

Signed-off-by: Artur Dębski <artur.debski@freedomfi.com>
@xbend xbend requested review from a team and m-trojanowski March 31, 2022 11:34
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Mar 31, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

Copy link
Contributor

@jkmar jkmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question:
Does that mean SAS can respond with 105 code on any type of request (not just Deregistration)?
I also wonder if there are any certification tests for that

@xbend
Copy link
Contributor Author

xbend commented Mar 31, 2022

@jkmar

One question: Does that mean SAS can respond with 105 code on any type of request (not just Deregistration)? I also wonder if there are any certification tests for that

According to WINNF-TS-0016, error codes 1XX are general errors related to the SAS-CBSD protocol. Documentation does not explicitly specify that those errors can occur on any request type, but that's the assumption - as SAS can internally deregister a CBSD at any time. Any CBSD that's communicating with SAS that has some sort of state, can issue any request according to their state machine, and SAS should/will respond exactly with error 105 indicating that the CBSD has been deregistered.

FreedomFi environment got this error initially on a heartbeat response for a CBSD, and then got the same error subsequently on each spectrum inquiry that followed after.

Certification testing documentation WINNF-TS-0122 has only 1 test case WINNF.FT.C.HBT.3 which targets handling of response code 105 for hearbeat requests, however section 6.7.1 about CBSD deregistration process says:

Deregistrations triggered by the SAS in a response message with a responseCode of
105 are covered in other test cases.

@xbend xbend merged commit 2c566a1 into magma:master Mar 31, 2022
@xbend xbend deleted the dp_fix_response_code_105_handling branch April 1, 2022 15:13
mattymo pushed a commit that referenced this pull request Apr 7, 2022
Fixed an issue where a CBSD state remained "registered" when SAS
returned a response with responseCode 105.
Response code 105 means the CBSD got unregistered in SAS and should
consider itself "Unregistered".
This PR changes the CBSD state to "unregistered" when any SAS response
is a 105 code.

Signed-off-by: Artur Dębski <artur.debski@freedomfi.com>

Co-authored-by: Artur Dębski <artur.debski@freedomfi.com>
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Fixed an issue where a CBSD state remained "registered" when SAS
returned a response with responseCode 105.
Response code 105 means the CBSD got unregistered in SAS and should
consider itself "Unregistered".
This PR changes the CBSD state to "unregistered" when any SAS response
is a 105 code.

Signed-off-by: Artur Dębski <artur.debski@freedomfi.com>

Co-authored-by: Artur Dębski <artur.debski@freedomfi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants