New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dp): Unregister CBSD on SAS response 105 #12360
Conversation
Fixed an issue where a CBSD state remained "registered" when SAS returned a response with reponseCode 105. Response code 105 means the CBSD got unregistered in SAS and should consider itself "Unregistered". This PR changes the CBSD state to "unregistered" when any SAS response is a 105 code. Signed-off-by: Artur Dębski <artur.debski@freedomfi.com>
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question:
Does that mean SAS can respond with 105 code on any type of request (not just Deregistration)?
I also wonder if there are any certification tests for that
According to WINNF-TS-0016, error codes 1XX are general errors related to the SAS-CBSD protocol. Documentation does not explicitly specify that those errors can occur on any request type, but that's the assumption - as SAS can internally deregister a CBSD at any time. Any CBSD that's communicating with SAS that has some sort of state, can issue any request according to their state machine, and SAS should/will respond exactly with error 105 indicating that the CBSD has been deregistered. FreedomFi environment got this error initially on a heartbeat response for a CBSD, and then got the same error subsequently on each spectrum inquiry that followed after. Certification testing documentation WINNF-TS-0122 has only 1 test case
|
Fixed an issue where a CBSD state remained "registered" when SAS returned a response with responseCode 105. Response code 105 means the CBSD got unregistered in SAS and should consider itself "Unregistered". This PR changes the CBSD state to "unregistered" when any SAS response is a 105 code. Signed-off-by: Artur Dębski <artur.debski@freedomfi.com> Co-authored-by: Artur Dębski <artur.debski@freedomfi.com>
Fixed an issue where a CBSD state remained "registered" when SAS returned a response with responseCode 105. Response code 105 means the CBSD got unregistered in SAS and should consider itself "Unregistered". This PR changes the CBSD state to "unregistered" when any SAS response is a 105 code. Signed-off-by: Artur Dębski <artur.debski@freedomfi.com> Co-authored-by: Artur Dębski <artur.debski@freedomfi.com>
Fixed an issue where a CBSD state remained "registered" when SAS
returned a response with reponseCode 105.
Response code 105 means the CBSD got unregistered in SAS and should
consider itself "Unregistered".
This PR changes the CBSD state to "unregistered" when any SAS response
is a 105 code.
Signed-off-by: Artur Dębski artur.debski@freedomfi.com
Summary
Additional Information