Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agw): Added python version requirement infromation #12376

Merged
merged 2 commits into from Apr 1, 2022
Merged

fix(agw): Added python version requirement infromation #12376

merged 2 commits into from Apr 1, 2022

Conversation

VinashakAnkitAman
Copy link
Member

Title

fix(agw): Added python version requirement information

Summary

The precommit script uses arguments that needs Python version 3.7 or above. This PR adds informative comment regarding python version requirement

Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com

@VinashakAnkitAman
fix(agw): Added python version requirement infromation
0b3c675 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@VinashakAnkitAman VinashakAnkitAman requested a review from a team April 1, 2022 20:12
@VinashakAnkitAman VinashakAnkitAman requested a review from a team as a code owner April 1, 2022 20:12
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022 •
edited

feg-workflow

    2 files  202 suites   32s ⏱️
362 tests 362 ✔️ 0 💤 0 ❌
376 runs  376 ✔️ 0 💤 0 ❌

Results for commit ae1aa6c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022 •
edited

agw-workflow

     77 files     122 suites   7m 2s ⏱️
1 133 tests 1 124 ✔️ 9 💤 0 ❌
1 134 runs  1 125 ✔️ 9 💤 0 ❌

Results for commit ae1aa6c.

♻️ This comment has been updated with latest results.

@VinashakAnkitAman
Added python version information to precommit script
ae1aa6c 
Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
@VinashakAnkitAman VinashakAnkitAman requested a review from a team April 1, 2022 21:40
@github-actions github-actions bot added the component: agw Access gateway-related issue label Apr 1, 2022
ardzoht
ardzoht approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@ardzoht ardzoht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@ardzoht ardzoht merged commit 0505172 into magma:master Apr 1, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@VinashakAnkitAman @emakeev
fix(agw): Added python version requirement infromation (magma#12376)
a8b75f1 
* fix(agw): Added python version requirement infromation

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>

* Added python version information to precommit script

Signed-off-by: VinashakAnkitAman <ankit.aman@radisys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardzoht ardzoht ardzoht approved these changes

@themarwhal themarwhal themarwhal approved these changes

@tmdzk tmdzk Awaiting requested review from tmdzk tmdzk was automatically assigned from magma/approvers-ci

Assignees
No one assigned
Labels
component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VinashakAnkitAman @ardzoht @themarwhal