Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: stale bot is far to agressive #12382

Merged
merged 1 commit into from Apr 27, 2022

Conversation

Neudrino
Copy link
Contributor

@Neudrino Neudrino commented Apr 4, 2022

Summary

Stale bot was introduced without TSC vote or any community announcement with #11933. Amongst the over 1250 closed issues were a lot of very valid and elaborate issues and proposals.

There are several issues with the current implementation which are addressed with this PR:

  • Configuration from the Bot was copied but no license header was given.
  • The wait time for the bot
    • was reduced below the default without reasoning.
    • is far too short and would even close issue from active developers just going for a vacation.
  • The exempt label list is incorrect and needs to be extended to work well with other automation.
    • The label should be called willfix and not status: willfix due to following reasons:
      • Inconsistency between wontfix and status: willfix vs. willfix label.
      • The label status: willfix was not created for the repository and is nowhere used.
      • The label willfix was created and is currently used 44 times.
    • Additional labels should be added, amongst others proposals, ready-to-merge PRs and issues created by the Sentry automation should likely never be closed automatically.
  • The comment text is misleading as
    • it only refers to PRs and not issues, while both are affected.
    • suggests that only authors and maintainers can take action while anybody can.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@Neudrino Neudrino requested a review from maxhbr April 4, 2022 14:46
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neudrino Neudrino marked this pull request as ready for review April 11, 2022 07:22
@maxhbr
Copy link
Member

maxhbr commented Apr 13, 2022

The only blocking CI check is checkRebase, I think it still can be reviewed.

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino requested a review from a team April 22, 2022 14:38
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@Neudrino Neudrino merged commit b9c1a54 into magma:master Apr 27, 2022
@Neudrino Neudrino deleted the ci/stale-bot-refinement-I branch April 27, 2022 10:43
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants