fix(nms): Initially load count of subscribers correctly #12383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
@andreilee Is there a good way to also get automatic updates in? I think it would be possible to do that in |
sebathomas
force-pushed
the
nms-subscriber-kpi
branch
2 times, most recently
from
3a53d11
to
92acf63
Compare
sebathomas
force-pushed
the
nms-subscriber-kpi
branch
from
92acf63
to
51113e7
Compare
sebathomas
force-pushed
the
nms-subscriber-kpi
branch
from
51113e7
to
66c43a2
Compare
|
Rebased. |
sebathomas
force-pushed
the
nms-subscriber-kpi
branch
from
66c43a2
to
7f585d6
Compare
andreilee
approved these changes
Apr 28, 2022
| @@ -43,6 +43,7 @@ export type SubscriberContextType = { | |||
| forbiddenNetworkTypes: {[string]: core_network_types}, | |||
| metrics?: {[string]: Metrics}, | |||
| gwSubscriberMap: {[gateway_id]: Array<subscriber_id>}, | |||
| totalCount: number, | |||
There was a problem hiding this comment.
nit: update the comments above
Fixes a bug where the number of subscribers shown in the KPI panel depends on the pagination of the subscriber table. Does not handle changes to the number without reload. Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
sebathomas
force-pushed
the
nms-subscriber-kpi
branch
from
7f585d6
to
ba1759f
Compare
sebathomas
added
the
ready2merge
emakeev
pushed a commit
to emakeev/magma
that referenced
this pull request
Aug 5, 2022
Fixes a bug where the number of subscribers shown in the KPI panel depends on the pagination of the subscriber table. Does not handle changes to the number without reload. Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where the number of subscribers shown in the KPI panel depends on the pagination of the subscriber table.
Does not handle changes to the number without reloading NMS.
Fixes #11929.
Thanks @Siddharthlende for investigating!
Done in pairing with @thmsschmitt.
Test Plan
Set up NMS locally with 98 subscribers.
Additional Information