fix: pin genproto to specific version to avoid envoyproxy/go-control-… #12386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…plane update
Signed-off-by: Oriol Batalla obatalla@fb.com
Summary
We are using envoy 0.9.4 on Magma. That version seems to be using specific versions of grpc and protobuf module.s
To update
envoy/go-control-plane
we need to refactor the code because the newest versions have a total different API.So in order to be able to use some new modules on magma we need to pin genproto version to prevent
envoy/go-control-plane
to automatically update on go.mod and break.Note in the near future this will break and envoy will need to be either updated or placed on a separate module.
Test Plan
make precommit
Additional Information