Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin genproto to specific version to avoid envoyproxy/go-control-… #12386

Merged
merged 1 commit into from Apr 4, 2022

Conversation

uri200
Copy link
Contributor

@uri200 uri200 commented Apr 4, 2022

…plane update

Signed-off-by: Oriol Batalla obatalla@fb.com

Summary

We are using envoy 0.9.4 on Magma. That version seems to be using specific versions of grpc and protobuf module.s

To update envoy/go-control-plane we need to refactor the code because the newest versions have a total different API.

So in order to be able to use some new modules on magma we need to pin genproto version to prevent envoy/go-control-plane to automatically update on go.mod and break.

Note in the near future this will break and envoy will need to be either updated or placed on a separate module.

Test Plan

make precommit

Additional Information

  • This change is backwards-breaking

…plane update

Signed-off-by: Oriol Batalla <obatalla@fb.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: feg FEG-gateway related issues label Apr 4, 2022
@uri200 uri200 requested review from emakeev and koolzz April 4, 2022 17:33
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

feg-workflow

    2 files  202 suites   32s ⏱️
363 tests 363 ✔️ 0 💤 0
377 runs  377 ✔️ 0 💤 0

Results for commit 9e1ec08.

@uri200 uri200 mentioned this pull request Apr 4, 2022
1 task
Copy link
Contributor

@emakeev emakeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uri200 uri200 merged commit 51adac4 into magma:master Apr 4, 2022
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: feg FEG-gateway related issues size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants