Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dp): Fix domain-proxy image building after regression from PR #12311 #12393

Merged
merged 1 commit into from Apr 5, 2022

Conversation

sklgromek
Copy link
Contributor

Signed-off-by: Tomasz Gromowski tomasz@freedomfi.com

Summary

Fix domain-proxy image building job in Skaffold introduced by Elasticsearch integration PR #12311

Test Plan

Additional Information

  • This change is backwards-breaking

@sklgromek sklgromek requested review from a team and jkmar April 5, 2022 08:26
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

…ma#12311

Signed-off-by: Tomasz Gromowski <tomasz@freedomfi.com>
@sklgromek sklgromek merged commit bf16d6a into magma:master Apr 5, 2022
@sklgromek sklgromek deleted the fix_dp_build_job branch April 5, 2022 11:07
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Unit Test Results

157 files  157 suites   2h 4m 50s ⏱️
307 tests 304 ✔️ 3 💤 0

Results for commit bf16d6a.

♻️ This comment has been updated with latest results.

emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants